Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2037: file formatting under multiplechoiceinput package #2049

Merged
merged 5 commits into from
Oct 29, 2020
Merged

Fix #2037: file formatting under multiplechoiceinput package #2049

merged 5 commits into from
Oct 29, 2020

Conversation

Arjupta
Copy link
Contributor

@Arjupta Arjupta commented Oct 27, 2020

Fixes #2037
Removed the one-line functions to segregate the initialisation logic in the starting of file

Explanation

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@Arjupta
Fix oppia#2037: file formatting under multiplechoiceinput package
c3f3061 
Removed the oneline functions to segregate the initialisation logic in the starting of file
@Arjupta Arjupta requested a review from anandwana001 October 27, 2020 09:57
anandwana001
anandwana001 suggested changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check the reference again on how to update the file.

@anandwana001 anandwana001 assigned Arjupta and unassigned Arjupta and anandwana001 Oct 27, 2020
@Arjupta
Copy link
Contributor Author

Arjupta commented Oct 27, 2020 •
edited
Loading

please check the reference again on how to update the file.

@anandwana001 I compared it with the reference file you mentioned in the issue. It looked similarly structured to me, can you suggest specific changes that you found
Thanks

@anandwana001
Copy link
Contributor

please check the reference again on how to update the file.

@anandwana001 I compared it with the reference file you mentioned in the issue. It looked similarly structured to me, can you suggest specific changes that you found
Thanks

Please use InteractionObjectTestBuilder as mentioned in the reference file.

@Arjupta
Copy link
Contributor Author

Arjupta commented Oct 27, 2020

please check the reference again on how to update the file.

@anandwana001 I compared it with the reference file you mentioned in the issue. It looked similarly structured to me, can you suggest specific changes that you found
Thanks

Please use InteractionObjectTestBuilder as mentioned in the reference file.

Have done those changes. PTAL

@Arjupta Arjupta requested a review from anandwana001 October 27, 2020 16:55
rt4914
rt4914 approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

anandwana001
anandwana001 suggested changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Arjupta
Left some comments.

...in/classify/rules/multiplechoiceinput/MultipleChoiceInputEqualsRuleClassifierProviderTest.kt Outdated Show resolved Hide resolved
...in/classify/rules/multiplechoiceinput/MultipleChoiceInputEqualsRuleClassifierProviderTest.kt Outdated Show resolved Hide resolved
@anandwana001 anandwana001 assigned Arjupta and unassigned anandwana001 Oct 28, 2020
@Arjupta Arjupta requested a review from anandwana001 October 28, 2020 15:55
anandwana001
anandwana001 suggested changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit changes. @Arjupta

...in/classify/rules/multiplechoiceinput/MultipleChoiceInputEqualsRuleClassifierProviderTest.kt Outdated Show resolved Hide resolved
...in/classify/rules/multiplechoiceinput/MultipleChoiceInputEqualsRuleClassifierProviderTest.kt Outdated Show resolved Hide resolved
@anandwana001 anandwana001 removed their assignment Oct 28, 2020
@Arjupta Arjupta requested a review from anandwana001 October 28, 2020 18:55
anandwana001
anandwana001 approved these changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @Arjupta

@anandwana001 anandwana001 removed their assignment Oct 28, 2020
@rt4914
Copy link
Contributor

rt4914 commented Oct 28, 2020

@anandwana001 Please resolve the comments above and assign it back to me for merging.

@rt4914 rt4914 assigned anandwana001 and unassigned rt4914 and Arjupta Oct 28, 2020
@anandwana001 anandwana001 assigned rt4914 and unassigned anandwana001 Oct 29, 2020
@rt4914 rt4914 merged commit 7a2a6f7 into oppia:develop Oct 29, 2020
@rt4914
Copy link
Contributor

rt4914 commented Oct 29, 2020

@aggarwalpulkit596 Please give respective points to @Arjupta . Thanks.

@aggarwalpulkit596
Copy link
Contributor

give @Arjupta 5 points

@Arjupta Arjupta deleted the reformating branch November 1, 2020 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anandwana001 anandwana001 anandwana001 approved these changes

@rt4914 rt4914 rt4914 approved these changes

Assignees

@rt4914 rt4914

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix file formatting under multiplechoiceinput package
4 participants
@Arjupta @anandwana001 @rt4914 @aggarwalpulkit596