Fix part of #138: Topic train fragment Low-fi UI (Part 1) #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 3, 2019
veena14cs
reviewed
Oct 3, 2019
| @@ -61,6 +61,7 @@ dependencies { | |||
| 'androidx.constraintlayout:constraintlayout:1.1.3', | |||
| 'androidx.core:core-ktx:1.0.2', | |||
| 'androidx.lifecycle:lifecycle-runtime-ktx:2.2.0-alpha03', | |||
| 'androidx.recyclerview:recyclerview:1.0.0', | |||
| 'com.google.dagger:dagger:2.24', | |||
| "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlin_version", | |||
| "org.jetbrains.kotlinx:kotlinx-coroutines-core:1.2.1", | |||
There was a problem hiding this comment.
single quotes not yet updated
There was a problem hiding this comment.
Actually, I mentioned this in my last PR (#197 ), I am only adding a new recyclerview and I prefer not to update someone else's PR. The double quotes has been mentioned from Ben's PR.
Later on we can solve such nit issues by creating a separate PR.
|
Merging this PR, as it looks up-to-date. |
rt4914
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Replicated from #197
Part 1: This PR contains basic XML files for creating TopicTrainFragment.
Part 2: #202
Part 3: #203
Part 4: #204
Mock: https://xd.adobe.com/spec/e2239cf4-9cde-4c08-5296-25316c1f0a14-9412/screen/f403add1-079a-4202-9975-efe04c076290/Home-Page-1-Start-Learning-Pre-Scroll-6
Checklist