Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #161: Exploration player contentcard supports rich-text #189
Fix #161: Exploration player contentcard supports rich-text #189
Changes from 5 commits
c3be8cf
be5ab3d
ae58b05
46dda13
c27f1a9
ed7eee3
b0464ab
cfa8e51
73d4a8f
e0f2265
7fd2e74
a7e6544
1f87e82
cea90f7
78ef537
f3a0d33
9719d1a
1dcd935
4bce854
5649d81
74889c1
630581e
70eeea8
e02ca5e
0580ed2
3977321
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to my comment in your other PR--let's move this to a general utility so that we don't need to repeat it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.5 dp
why? I suggest not using such values, probably we should be them in multiple of4
or sometimes2
if required.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks too thick if I update to 2.