Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #124: Introduce basic stub for AnswerClassificationController #187

Merged
merged 1 commit into from
Sep 27, 2019

Conversation

BenHenning
Copy link
Member

This is a very basic version of the answer classification controller that just returns the interaction's default outcome. This seems sufficient since the controller should only be used by progress controllers (e.g. #112 and #119) and not by the UI.

For that reason, please review this based on what the final architecture should be for the prototype. Note that this does not set up the classification in the same way as Oppia web wherein we modularize classification for each interaction. That will be up to the implementation per #114, but it may be more practical just to keep all prototype interaction classification code within this controller in the interim.

Copy link
Contributor

@jamesxu0 jamesxu0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BenHenning
Copy link
Member Author

Thanks @jamesxu0!

@BenHenning BenHenning merged commit 4e870d0 into develop Sep 27, 2019
@BenHenning BenHenning deleted the introduce-answer-classification-controller branch September 27, 2019 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants