-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes part of #59: Build app module views + view models with Bazel #1581
Conversation
…-android into stage1_bazel_testing
…-android into stage1_bazel_testing
…into stage1_bazel_utility
….com/oppia/oppia-android into introduce-domain-bazel-build
… build-app-viewmodels-bazel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @miaboloix! This looks pretty close to done. Just had a few more comments.
app/src/main/java/org/oppia/app/databinding/TextViewBindingAdapters.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/oppia/app/topic/questionplayer/QuestionPlayerViewModel.kt
Show resolved
Hide resolved
app/src/main/java/org/oppia/app/topic/questionplayer/QuestionPlayerFragmentPresenter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/oppia/app/topic/questionplayer/QuestionPlayerViewModel.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @miaboloix! Overall LGTM, but the questions piece needs to be finished.
app/src/main/java/org/oppia/app/player/state/StateFragmentPresenter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/oppia/app/topic/questionplayer/QuestionPlayerFragmentPresenter.kt
Outdated
Show resolved
Hide resolved
Also @miaboloix is this still blocked on #1568 per the title? |
#1568 was merged, so it is unblocked now! I will rename it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @miaboloix, LGTM!
@miaboloix Are we intentionally removing the vcs.xml file? |
No - this is a mistake. I meant to remove the file from the change list but I must have deleted it instead. Can I just revert this commit? |
Explanation
Fixes part of #59: Build app module view models with Bazel [BLOCKED: #1568]
In order to build app module in Bazel, parts of the module must be built before others in order to avoid circular dependencies and in order for data-binding to work.
In this PR, I am building the module's view models and views - which require certain listeners, resources, and annotation files (built in their own libraries). You will notice that I am building a
resources
library that excludes all layout resource files. This is necessary because layout files depend on view models, views, and binding adapters while binding adapters depend on view models.See the graph below:
This is a visual representation of the libraries app module will have and how they will depend on eachother. The libraries in green are libraries implemented in this PR. The libraries in grey are implemented in PRs to follow.
Here is a quick summary of each library's function:
org/oppia/app/databinding/
org/oppia/app/recyclerview/
NOTES:
To build
views
, runTo build
view_models
, runChecklist