Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options-multipane screen (tablet) (low-fi) - Part 1 #1551

Closed
wants to merge 3 commits into from

Conversation

MohamedMedhat1998
Copy link
Contributor

@MohamedMedhat1998 MohamedMedhat1998 commented Aug 3, 2020

Explanation

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@rt4914
Copy link
Contributor

rt4914 commented Aug 5, 2020

@MohamedMedhat1998 Please add mock links to issues as well as this PR because I need reference to what I should check it with.

@rt4914 rt4914 assigned MohamedMedhat1998 and unassigned rt4914 Aug 5, 2020
@MohamedMedhat1998
Copy link
Contributor Author

@MohamedMedhat1998 Please add mock links to issues as well as this PR because I need reference to what I should check it with.

Done

@MohamedMedhat1998
Copy link
Contributor Author

Closing because this work is completed in #1677

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants