Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #513: Removed math latex tag from explorations #1509

Merged
merged 2 commits into from
Jul 23, 2020

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Jul 23, 2020

Explanation

Fix #513

Currently two explorations contain math-latex tag and this PR removes them all.

Note:

  1. I have posted screenshots below which explains how things have changed before and after.
  2. Some math-latex was in different language so I have changed it but we cannot check that and that's not an issue because in future even the json files won't have math-latex tag, so that's not an issue.

Before / After 1

Screenshot_1595461878
Screenshot_1595462434

Before/After 2

Screenshot_20191204-160515
Screenshot_1595463128

Before/After 3

Screenshot_20191204-160733
Screenshot_1595463461

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks

@anandwana001 anandwana001 assigned rt4914 and unassigned anandwana001 Jul 23, 2020
@rt4914 rt4914 merged commit aa2d8d5 into develop Jul 23, 2020
@rt4914 rt4914 deleted the update-exploration-content branch July 23, 2020 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In Some explorations expressions are missing.
2 participants