Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1104: Offline Exception Logging #1500

Merged
merged 34 commits into from
Aug 11, 2020
Merged

Fix #1104: Offline Exception Logging #1500

merged 34 commits into from
Aug 11, 2020

Conversation

Sarthak2601
Copy link
Contributor

Explanation

Fixes #1104
Fixes part of #1105

  • Adds the proto structure for exception logs
  • Adds exception controller for storing/uploading of exception logs on the basis of network connectivity.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@Sarthak2601 Sarthak2601 requested a review from vinitamurthi July 22, 2020 11:06
@vinitamurthi vinitamurthi removed their assignment Jul 22, 2020
vinitamurthi
vinitamurthi suggested changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@vinitamurthi vinitamurthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more structure question. I wonder if it makes more sense to keep the exception serialization and deserialization (i.e. exceptionToExceptionLog() and exceptionLogtoException) in a separate class considering that multiple codepaths will be deserializing these exceptions @BenHenning thoughts?

domain/src/main/java/org/oppia/domain/oppialogger/crashlytics/ExceptionsController.kt Outdated Show resolved Hide resolved
domain/src/main/java/org/oppia/domain/oppialogger/crashlytics/ExceptionsController.kt Outdated Show resolved Hide resolved
domain/src/main/java/org/oppia/domain/oppialogger/crashlytics/ExceptionsController.kt Outdated Show resolved Hide resolved
domain/src/main/java/org/oppia/domain/oppialogger/crashlytics/ExceptionsController.kt Outdated Show resolved Hide resolved
domain/src/main/java/org/oppia/domain/oppialogger/crashlytics/ExceptionsController.kt Outdated Show resolved Hide resolved
@vinitamurthi vinitamurthi requested a review from BenHenning July 23, 2020 05:58
BenHenning
BenHenning requested changes Jul 24, 2020
View reviewed changes
Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Sarthak2601--did a first pass.

domain/src/main/java/org/oppia/domain/oppialogger/crashlytics/ExceptionsController.kt Outdated Show resolved Hide resolved
domain/src/main/java/org/oppia/domain/oppialogger/crashlytics/ExceptionsController.kt Outdated Show resolved Hide resolved
model/src/main/proto/oppia_logger.proto Outdated Show resolved Hide resolved
model/src/main/proto/oppia_logger.proto Outdated Show resolved Hide resolved
model/src/main/proto/oppia_logger.proto Outdated Show resolved Hide resolved
domain/src/main/java/org/oppia/domain/oppialogger/crashlytics/ExceptionsController.kt Outdated Show resolved Hide resolved
domain/src/main/java/org/oppia/domain/oppialogger/crashlytics/ExceptionsController.kt Outdated Show resolved Hide resolved
domain/src/main/java/org/oppia/domain/oppialogger/crashlytics/ExceptionsController.kt Outdated Show resolved Hide resolved
domain/src/main/java/org/oppia/domain/oppialogger/crashlytics/ExceptionsController.kt Outdated Show resolved Hide resolved
domain/src/main/java/org/oppia/domain/oppialogger/crashlytics/ExceptionsController.kt Outdated Show resolved Hide resolved
@BenHenning BenHenning removed their assignment Jul 24, 2020
vinitamurthi
vinitamurthi approved these changes Jul 26, 2020
View reviewed changes
Copy link
Contributor

@vinitamurthi vinitamurthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, just a few comments!

domain/src/main/java/org/oppia/domain/oppialogger/exceptions/ExceptionsController.kt Outdated Show resolved Hide resolved
domain/src/main/java/org/oppia/domain/oppialogger/exceptions/ExceptionsController.kt Outdated Show resolved Hide resolved
model/src/main/proto/oppia_logger.proto Outdated Show resolved Hide resolved
@vinitamurthi vinitamurthi removed their assignment Jul 26, 2020
@vinitamurthi vinitamurthi removed their assignment Aug 5, 2020
BenHenning
BenHenning reviewed Aug 11, 2020
View reviewed changes
Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more comments.

domain/src/test/java/org/oppia/domain/oppialogger/exceptions/ExceptionsControllerTest.kt Outdated
@Singleton
@Provides
@TestDispatcher
fun provideTestDispatcher(): CoroutineDispatcher {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don’t do this. You should include the test dispatcher module, instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

domain/src/test/java/org/oppia/domain/oppialogger/exceptions/ExceptionsControllerTest.kt Outdated Show resolved Hide resolved
@BenHenning BenHenning removed their assignment Aug 11, 2020
@Sarthak2601 Sarthak2601 requested a review from BenHenning August 11, 2020 04:31
BenHenning
BenHenning approved these changes Aug 11, 2020
View reviewed changes
Copy link
Member

@BenHenning BenHenning left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM @Sarthak2601!

@BenHenning BenHenning removed their assignment Aug 11, 2020
@vinitamurthi
Copy link
Contributor

Please merge develop to this branch!

@Sarthak2601 Sarthak2601 merged commit 6807ca7 into develop Aug 11, 2020
@Sarthak2601 Sarthak2601 deleted the exception-log-offline branch August 11, 2020 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenHenning BenHenning BenHenning approved these changes

@vinitamurthi vinitamurthi vinitamurthi approved these changes

Assignees

@Sarthak2601 Sarthak2601

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Offline Exception Logging [GSoC'20][Milestone 3]
3 participants
@Sarthak2601 @vinitamurthi @BenHenning