Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP part of #161: Exploration player base 2 contentcard #125
WIP part of #161: Exploration player base 2 contentcard #125
Changes from all commits
4908754
8e45390
c6292d8
77a166d
451cb3f
10768a3
e257140
2d7e210
55c5555
78acf19
5639984
f0ff783
79bacd9
b35d61f
8cb1144
bb23fb7
4546b61
6a8cb0a
996a31f
4eec3c8
9e2280c
9a461ab
f66a8c6
bfa2755
71ff163
1cc254a
8118bf9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest diffbasing off of #172 and seeing that generic structure simplifies this adapter. I think you could use a ViewModel to perform the
Html
wrap calls, and then you can just rely on vanilla data-binding methods for inflating the view & binding the view model. That hopefully will result in you not needing this adapter class at all.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I just noticed you did pull in the bindable adapter below--can you update this PR to be diffbased off of #172 to make the history a bit cleaner?
Also, if that adapter works can you remove this one? Feel free to not address any of the comments in this class (minus the one suggesting to use the proto structures instead of the GAE ones), though I do suggest reading through them for your reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@veena14cs can we use the bindable adapter here, instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is meant by "right interaction"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is learner's interaction to be displayed on right side of the view
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't use positional language like 'left/right' since they may be reversed in RTL layouts.
Beyond that, I'm not sure I understand the directionality here. Per the mocks the interaction appears below the content area.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned here & elsewhere: let's instead use the structures defined in exploration.proto instead of GAE structures since the UI should never depend on the latter.