Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #632: BindableAdapter for HomeFragment[DO NOT MERGE] #1030

Closed

Conversation

NullByte08
Copy link
Contributor

@NullByte08 NullByte08 commented Apr 29, 2020

Explanation

#632 HomeFragment:

There are errors coming in the implementation.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@NullByte08 NullByte08 requested a review from rt4914 April 29, 2020 08:21
@NullByte08
Copy link
Contributor Author

@rt4914 Please take a look at the code and tell me whether I am implementing the ViewModel classes in the right way. I am having problems in implementing the list of promoted stories. Should I create a design doc regarding this?

@rt4914
Copy link
Contributor

rt4914 commented May 4, 2020

@rt4914 Please take a look at the code and tell me whether I am implementing the ViewModel classes in the right way. I am having problems in implementing the list of promoted stories. Should I create a design doc regarding this?

@NullByte08 Actually I haven't been able to find an issue yet. Maybe a design doc can be a good idea. So that I can defer it to Ben who can bring in more light on this. Mostly I am assuming that the BindableAdapter itself will need to be modified to support HomeFragment items.

@rt4914 rt4914 assigned NullByte08 and unassigned rt4914 May 4, 2020
@NullByte08
Copy link
Contributor Author

@rt4914 Ok

@rt4914
Copy link
Contributor

rt4914 commented Jun 12, 2020

Closing this PR as there has been no updates on this PR from contributor.

@rt4914 rt4914 closed this Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants