Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Not able to navigate back from story. #5267

Closed
Vishwajith-Shettigar opened this issue Dec 11, 2023 · 6 comments · Fixed by #5278
Closed

[BUG]: Not able to navigate back from story. #5267

Vishwajith-Shettigar opened this issue Dec 11, 2023 · 6 comments · Fixed by #5278
Assignees
@Vishwajith-Shettigar
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Work: Low Solution is clear and broken into good-first-issue-sized chunks.

Comments

@Vishwajith-Shettigar
Copy link
Collaborator

Vishwajith-Shettigar commented Dec 11, 2023 •
edited
Loading

Describe the bug

when user click on view all in stories for you and open any story, user will be stuck, there is no way to go back to home.

Steps To Reproduce

  1. Click on view all
  2. open any story
  3. click on close icon and try to go back.

Expected Behavior

Clicking back or close button should navigate back.

Screenshots/Videos

storyissue.webm

What device/emulator are you using?

No response

Which Android version is your device/emulator running?

No response

Which version of the Oppia Android app are you using?

No response

Additional Context

No response
@Vishwajith-Shettigar Vishwajith-Shettigar added bug End user-perceivable behaviors which are not desirable. triage needed good first issue This item is good for new contributors to make their pull request. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). and removed triage needed good first issue This item is good for new contributors to make their pull request. labels Dec 11, 2023
@Cyclotron17
Copy link

Hello I want to work in this issue

@MohitGupta121
Copy link
Member

@Cyclotron17 please brief your approach, if that's look good then we assign you the issue.

@prabhakar0304
Copy link

I tried to reproduce the bug but everything was working fine.

Device Info

Device : Galaxy S21 FE
Android Version : 13
App Version: 0.11-beta-3343155232

@Vishwajith-Shettigar
Copy link
Collaborator Author

Vishwajith-Shettigar commented Dec 15, 2023 •
edited
Loading

I tried to reproduce the bug but everything was working fine.

Device Info

Device : Galaxy S21 FE Android Version : 13 App Version: 0.11-beta-3343155232

@prabhakar0304, are you trying to reproduce the issue with Play Store version?

@Vishwajith-Shettigar Vishwajith-Shettigar added the Work: Low Solution is clear and broken into good-first-issue-sized chunks. label Dec 19, 2023
@Vishwajith-Shettigar Vishwajith-Shettigar self-assigned this Dec 19, 2023
Merged
6 tasks
@predator313
Copy link

hey is this issue still remain?? I want to work on this

@Vishwajith-Shettigar
Copy link
Collaborator Author

Hi @predator313, this issue already has PR, can you go with other issues ?

adhiamboperes added a commit that referenced this issue Feb 26, 2024
@Vishwajith-Shettigar @adhiamboperes
Fix #5267: Not able to navigate back from story. (#5278)
005672e 
<!-- READ ME FIRST: Please fill in the explanation section below and
check off every point from the Essential Checklist! -->
## Explanation
<!--
- Explain what your PR does. If this PR fixes an existing bug, please
include
- "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
issue
  - when this PR is merged.
  -->
Fixes #5267
Destroyed ExplorationActivity before creating TopicActivity to prevent
loop between the same two activity, when user tries to go back.

## Essential Checklist
<!-- Please tick the relevant boxes by putting an "x" in them. -->
- [x] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [x] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [ ] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [x] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).

## For UI-specific PRs only
## Before

[no_way_home.webm](https://github.com/oppia/oppia-android/assets/76042077/8c2afa69-9237-4f0d-8b53-f1e89851bd4a)

## After

[home_coming.webm](https://github.com/oppia/oppia-android/assets/76042077/92e3bc79-b042-4610-bed5-def7dda2da2c)

<!-- Delete these section if this PR does not include UI-related
changes. -->
If your PR includes UI-related changes, then:
- Add screenshots for portrait/landscape for both a tablet & phone of
the before & after UI changes
- For the screenshots above, include both English and pseudo-localized
(RTL) screenshots (see [RTL
guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines))
- Add a video showing the full UX flow with a screen reader enabled (see
[accessibility
guide](https://github.com/oppia/oppia-android/wiki/Accessibility-A11y-Guide))
- For PRs introducing new UI elements or color changes, both light and
dark mode screenshots must be included
- Add a screenshot demonstrating that you ran affected Espresso tests
locally & that they're passing

---------

Co-authored-by: Adhiambo Peres <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vishwajith-Shettigar Vishwajith-Shettigar

Labels
bug End user-perceivable behaviors which are not desirable. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Work: Low Solution is clear and broken into good-first-issue-sized chunks.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #5267: Not able to navigate back from story. Vishwajith-Shettigar/oppia-android
5 participants
@Vishwajith-Shettigar @MohitGupta121 @predator313 @prabhakar0304 @Cyclotron17