Dark mode bugs in Alert Dailogs #4950
Assignees
Comments
github-project-automation
bot
moved this to Todo
in [Team] Core Learner and Mastery flows & UI Frontend - Android
MohitGupta121
moved this from Todo
to In Progress
in [Team] Core Learner and Mastery flows & UI Frontend - Android
6 tasks
BenHenning
added a commit
that referenced
this issue
Apr 21, 2023
…t Dark Mode (#4946) <!-- READ ME FIRST: Please fill in the explanation section below and check off every point from the Essential Checklist! --> ## Explanation Fix #4950 : Audio Language Dialog Items and Hints & Solution link text Dark Mode <!-- - Explain what your PR does. If this PR fixes an existing bug, please include - "Fixes #bugnum:" in the explanation so that GitHub can auto-close the issue - when this PR is merged. --> ## Essential Checklist <!-- Please tick the relevant boxes by putting an "x" in them. --> - [x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".) - [x] Any changes to [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets) files have their rationale included in the PR explanation. - [x] The PR follows the [style guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide). - [x] The PR does not contain any unnecessary code changes from Android Studio ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)). - [x] The PR is made from a branch that's **not** called "develop" and is up-to-date with "develop". - [x] The PR is **assigned** to the appropriate reviewers ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)). ## For UI-specific PRs only ### Audio Language Dialog | Before - Light Mode | Before - Dark Mode | | ------ | ------ | | <img src="https://user-images.githubusercontent.com/76530270/232176309-96baccba-1dbe-4d9c-90b3-0a3745792890.png" height="400" style="max-width: 100%"> | <img src="https://user-images.githubusercontent.com/76530270/232176298-0eb99d85-59a5-4d7a-8625-079880c7f1f8.png" height="400" style="max-width: 100%"> | | After - Light Mode | After - Dark Mode | | ------ | ------ | | <img src="https://user-images.githubusercontent.com/76530270/232559041-1068be59-35ba-49d6-88bc-6c08365a46d3.png" height="400" style="max-width: 100%"> | <img src="https://user-images.githubusercontent.com/76530270/232559017-7c5c8fd8-f2c2-418e-825d-3834869ba5c1.png" height="400" style="max-width: 100%"> | ### Currently Offline Dialog | Before - Light Mode | Before - Dark Mode | | ------ | ------ | | <img src="https://user-images.githubusercontent.com/76530270/232840612-5783ab54-4792-49b7-bbe0-948f59cece19.png" height="400" style="max-width: 100%"> | <img src="https://user-images.githubusercontent.com/76530270/232840570-c609e0de-9b8f-4bcb-9045-cc6f89b31cfe.png" height="400" style="max-width: 100%"> | | After - Light Mode | After - Dark Mode | | ------ | ------ | | <img src="https://user-images.githubusercontent.com/76530270/232840983-d96b39f7-cbe2-44d5-b779-078e66776dfc.png" height="400" style="max-width: 100%"> | <img src="https://user-images.githubusercontent.com/76530270/232840952-7cd7149b-dd3b-4fe8-888e-7b2457eeb42c.png" height="400" style="max-width: 100%"> | ### Currently on Cellular Data Dialog | Light Mode | Dark Mode | | ------ | ------ | | <img src="https://user-images.githubusercontent.com/76530270/232841897-2603a8b9-830d-4851-b06d-e0b14f57ef4d.png" height="400" style="max-width: 100%"> | <img src="https://user-images.githubusercontent.com/76530270/232841872-68b515a5-c985-4530-933a-61da7e24e180.png" height="400" style="max-width: 100%"> | | Light Mode | Dark Mode | | ------ | ------ | | <img src="https://user-images.githubusercontent.com/76530270/232841822-699020fa-e659-4868-bc2e-307bd1fd7f3b.png" height="400" style="max-width: 100%"> | <img src="https://user-images.githubusercontent.com/76530270/232841794-410e8a0c-2a4e-4e73-8a49-d6ed1bfb4e5a.png" height="400" style="max-width: 100%"> | ### Profile Picture Dialog | Light Mode | Dark Mode | | ------ | ------ | | <img src="https://user-images.githubusercontent.com/76530270/232842467-8afdec2d-3150-4d5c-92b4-a8a3a21249a4.png" height="400" style="max-width: 100%"> | <img src="https://user-images.githubusercontent.com/76530270/232842451-0c065ee4-fc07-466f-b991-81b83bed1fb5.png" height="400" style="max-width: 100%"> | ### Leave to Topic Page Dialog | Light Mode | Dark Mode | | ------ | ------ | | <img src="https://user-images.githubusercontent.com/76530270/232842897-86b4b13c-9915-48e3-af3c-8f104c175f6b.png" height="400" style="max-width: 100%"> | <img src="https://user-images.githubusercontent.com/76530270/232842912-c23de78b-8905-4c9b-b061-e056a9389f76.png" height="400" style="max-width: 100%"> | ### Show Solution Dialog | Light Mode | Dark Mode | | ------ | ------ | | <img src="https://user-images.githubusercontent.com/76530270/232843213-8c9630f6-cd0e-4cb2-af29-d88d87d8e023.png" height="400" style="max-width: 100%"> | <img src="https://user-images.githubusercontent.com/76530270/232843207-37e320f0-ee9a-49cd-8d48-fea95d265ba0.png" height="400" style="max-width: 100%"> | ### Logout Alert Dialog | Light Mode | Dark Mode | | ------ | ------ | | <img src="https://user-images.githubusercontent.com/76530270/232843561-515d41e2-509a-4428-a3ff-acbd2cd4ef71.png" height="400" style="max-width: 100%"> | <img src="https://user-images.githubusercontent.com/76530270/232843547-4cba976c-f0fa-4a34-a7aa-57cafb9aafc9.png" height="400" style="max-width: 100%"> | ### Mark Chapter Complete Dialog | Light Mode | Dark Mode | | ------ | ------ | | <img src="https://user-images.githubusercontent.com/76530270/232843800-7c5940e8-6d10-4a24-8c7b-f92bfba801fe.png" height="400" style="max-width: 100%"> | <img src="https://user-images.githubusercontent.com/76530270/232843792-b0c60772-3734-44bf-9778-0e72b0ac04a5.png" height="400" style="max-width: 100%"> | ### Exit Profile Dialog | Light Mode | Dark Mode | | ------ | ------ | | <img src="https://user-images.githubusercontent.com/76530270/232843989-9f1fd9b0-8513-4448-9f74-23b711ce08ef.png" height="400" style="max-width: 100%"> | <img src="https://user-images.githubusercontent.com/76530270/232843977-99fe3e4e-d27d-4f19-9c38-52d04c883593.png" height="400" style="max-width: 100%"> | ### Pin Detail Dialog | Light Mode | Dark Mode | | ------ | ------ | | <img src="https://user-images.githubusercontent.com/76530270/232844287-a1519fd1-8ef3-4cb2-ab9e-a5eeefeb55c4.png" height="400" style="max-width: 100%"> | <img src="https://user-images.githubusercontent.com/76530270/232844277-efbac148-6642-44f8-8b35-4b5e5598b4a7.png" height="400" style="max-width: 100%"> | ### Forgot Pin Dialog | Light Mode | Dark Mode | | ------ | ------ | | <img src="https://user-images.githubusercontent.com/76530270/232845094-3fc90836-dadd-4993-a392-75323c86e6e1.png" height="400" style="max-width: 100%"> | <img src="https://user-images.githubusercontent.com/76530270/232845084-32a7821f-8d5a-4b84-bd28-196c9f684184.png" height="400" style="max-width: 100%"> | ### Confirm Oppia Data Reset Dialog | Light Mode | Dark Mode | | ------ | ------ | | <img src="https://user-images.githubusercontent.com/76530270/232845343-25d387a9-fec6-4600-92b8-bc40458b10df.png" height="400" style="max-width: 100%"> | <img src="https://user-images.githubusercontent.com/76530270/232845331-71dbb0a5-9c20-4bf5-8ab3-8387664debd0.png" height="400" style="max-width: 100%"> | ### Access to Administrator Settings Dialog | Light Mode | Dark Mode | | ------ | ------ | | <img src="https://user-images.githubusercontent.com/76530270/232845826-ecc9112e-d040-4e59-8b99-313b53b15e39.png" height="400" style="max-width: 100%"> | <img src="https://user-images.githubusercontent.com/76530270/232845809-8484a1e2-3f1b-4c50-976d-666ee3eaf55b.png" height="400" style="max-width: 100%"> | ### Maximum storage capacity reached Dialog | Light Mode | Dark Mode | | ------ | ------ | | <img src="https://user-images.githubusercontent.com/76530270/232871826-1adff718-8371-4fdd-a925-0f748d985c44.png" height="400" style="max-width: 100%"> | <img src="https://user-images.githubusercontent.com/76530270/232871812-6aa2eeed-4378-47d6-ad09-30fd664748a1.png" height="400" style="max-width: 100%"> | ### Hints & Solution | Before - Light Mode | Before - Dark Mode | | ------ | ------ | | <img src="https://user-images.githubusercontent.com/76530270/232176376-4572bc89-bb2e-4792-9e88-f0e0b57b95bd.png" height="400" style="max-width: 100%"> | <img src="https://user-images.githubusercontent.com/76530270/232176375-14ab518c-0bc2-40bd-8dad-b6ca7ad19bf4.png" height="400" style="max-width: 100%"> | | After - Light Mode | After - Dark Mode | | ------ | ------ | | <img src="https://user-images.githubusercontent.com/76530270/231985173-4b91f745-0029-4d0b-bb00-0872eb2d8a53.png" height="400" style="max-width: 100%"> | <img src="https://user-images.githubusercontent.com/76530270/231985184-5158c5cc-43d4-4d2b-acb3-f60ddd79d67d.png" height="400" style="max-width: 100%"> | <!-- Delete these section if this PR does not include UI-related changes. --> If your PR includes UI-related changes, then: - Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes - For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see [RTL guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines)) - Add a video showing the full UX flow with a screen reader enabled (see [accessibility guide](https://github.com/oppia/oppia-android/wiki/Accessibility-A11y-Guide)) - Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing --------- Co-authored-by: Ben Henning <[email protected]>
github-project-automation
bot
moved this from In Progress
to Done
in [Team] Core Learner and Mastery flows & UI Frontend - Android
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Dark mode bugs in Alert Dailogs:
Audio Language Dialog
Currently Offline Dialog
The text was updated successfully, but these errors were encountered: