Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README.md file is not updated. #4934

Closed
prafulbbandre opened this issue Mar 31, 2023 · 4 comments · Fixed by #4927
Closed

README.md file is not updated. #4934

prafulbbandre opened this issue Mar 31, 2023 · 4 comments · Fixed by #4927
Assignees
@prafulbbandre

Comments

@prafulbbandre
Copy link
Contributor

Describe the bug
The opia android app is launch but the readme.md app says that it is not yet launch.

Screenshot from 2023-03-31 23-39-26

Now as the android app is launched it must be updated as

Screenshot from 2023-03-31 23-47-42
@prafulbbandre prafulbbandre mentioned this issue Mar 31, 2023
Merged
6 tasks
@BenHenning
Copy link
Member

BenHenning commented Apr 1, 2023 •
edited
Loading

I think it's fine to update the README text (nice find!), but the app is technically not broadly launched yet (since it's still in beta). Perhaps instead:

The Android app is frontend for Oppia that provides...household. The app is now available in beta and can be installed from the [Play Store](https://play.google.com/store/apps/details?id=org.oppia.android).

This provides the actual link to the app listing, and clarifies it's in beta (and no longer new).

@prafulbbandre
Copy link
Contributor Author

@BenHenning so should i replace the old lines with the new one you provided.

@BenHenning
Copy link
Member

@BenHenning so should i replace the old lines with the new one you provided.

Yep I think that would be clearer @prafulbbandre.

@prafulbbandre
Copy link
Contributor Author

@BenHenning can you assign this task to me?

BenHenning added a commit that referenced this issue May 3, 2023
@prafulbbandre @BenHenning
Fix #4934:updated the readme.md file (#4927)
bf47f91 
<!-- READ ME FIRST: Please fill in the explanation section below and
check off every point from the Essential Checklist! -->
## Explanation
<!--
- Explain what your PR does. If this PR fixes an existing bug, please
include
- "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
issue
  - when this PR is merged.
  -->
Fixes #4934:Update readme.md file

## Essential Checklist
<!-- Please tick the relevant boxes by putting an "x" in them. -->
- [X] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [X] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [X] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [X] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [X] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [X] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).

## For UI-specific PRs only
<!-- Delete these section if this PR does not include UI-related
changes. -->
If your PR includes UI-related changes, then:
- Add screenshots for portrait/landscape for both a tablet & phone of
the before & after UI changes
- For the screenshots above, include both English and pseudo-localized
(RTL) screenshots (see [RTL
guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines))
- Add a video showing the full UX flow with a screen reader enabled (see
[accessibility
guide](https://github.com/oppia/oppia-android/wiki/Accessibility-A11y-Guide))
- Add a screenshot demonstrating that you ran affected Espresso tests
locally & that they're passing

---------

Co-authored-by: Ben Henning <[email protected]>
Co-authored-by: Ben Henning <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prafulbbandre prafulbbandre

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #4934:updated the readme.md file prafulbbandre/oppia-android
2 participants
@BenHenning @prafulbbandre