Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the unused condition from lessons_completed_chapter_view.xml for Accessibility #4888

Closed
MohitGupta121 opened this issue Mar 6, 2023 · 0 comments · Fixed by #4889
Closed

Remove the unused condition from lessons_completed_chapter_view.xml for Accessibility #4888

MohitGupta121 opened this issue Mar 6, 2023 · 0 comments · Fixed by #4889
Assignees
@MohitGupta121

Comments

@MohitGupta121
Copy link
Member

Currently we using viewModel.chapterPlayState != ChapterPlayState.NOT_PLAYABLE_MISSING_PREREQUISITES condition ForAccessibility which is always True in lessons_completed_chapter_view.xml , So we can remove this condition and directly use the true value.
@MohitGupta121 MohitGupta121 self-assigned this Mar 6, 2023
@MohitGupta121 MohitGupta121 mentioned this issue Mar 6, 2023
Merged
6 tasks
rt4914 added a commit that referenced this issue Mar 11, 2023
@MohitGupta121 @rt4914
Fixed #4888 : Remove the unused condition from lessons_completed_chap…
90347ac 
…ter_view.xml for Accessibility (#4889)

<!-- READ ME FIRST: Please fill in the explanation section below and
check off every point from the Essential Checklist! -->
## Explanation

Fixed #4888 : Remove the unused condition from
lessons_completed_chapter_view.xml for Accessibility


<!--
- Explain what your PR does. If this PR fixes an existing bug, please
include
- "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
issue
  - when this PR is merged.
  -->

## Essential Checklist
<!-- Please tick the relevant boxes by putting an "x" in them. -->
- [x] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [x] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [x] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [x] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).

## For UI-specific PRs only
<!-- Delete these section if this PR does not include UI-related
changes. -->
If your PR includes UI-related changes, then:
- Add screenshots for portrait/landscape for both a tablet & phone of
the before & after UI changes
- For the screenshots above, include both English and pseudo-localized
(RTL) screenshots (see [RTL
guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines))
- Add a video showing the full UX flow with a screen reader enabled (see
[accessibility
guide](https://github.com/oppia/oppia-android/wiki/Accessibility-(A11y)-Guide))
- Add a screenshot demonstrating that you ran affected Espresso tests
locally & that they're passing

Co-authored-by: Rajat Talesra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MohitGupta121 MohitGupta121

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed #4888 : Remove the unused condition from lessons_completed_chapter_view.xml for Accessibility
1 participant
@MohitGupta121