Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dark mode support to SpotLight Overlay #4861

Closed
MohitGupta121 opened this issue Jan 26, 2023 · 0 comments · Fixed by #4863
Closed

Add dark mode support to SpotLight Overlay #4861

MohitGupta121 opened this issue Jan 26, 2023 · 0 comments · Fixed by #4863
Assignees

Comments

@MohitGupta121
Copy link
Member

MohitGupta121 commented Jan 26, 2023

Describe the bug

Add dark mode support to SpotLight Overlay.

To Reproduce
Steps to reproduce the behavior:

  1. Turn on your emulator dark-mode
  2. Change this parameter to true to enable spotlight.
  3. Go to the Home screen
  4. See spotlight not visible

@MohitGupta121 MohitGupta121 self-assigned this Jan 26, 2023
rt4914 pushed a commit that referenced this issue Jan 30, 2023
<!-- READ ME FIRST: Please fill in the explanation section below and
check off every point from the Essential Checklist! -->
## Explanation

Fixed #4861 : Dark Mode for SpotLight Overlays


<!--
- Explain what your PR does. If this PR fixes an existing bug, please
include
- "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
issue
  - when this PR is merged.
  -->

## Essential Checklist
<!-- Please tick the relevant boxes by putting an "x" in them. -->
- [x] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [ ] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [x] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [x] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).

## For UI-specific PRs only

### Spotlight Overlays

<img
src="https://user-images.githubusercontent.com/76530270/215339838-8b82b4b7-2ad9-4293-b21c-6e8de6aee26c.png"
height="400" style="max-width: 100%"> <img
src="https://user-images.githubusercontent.com/76530270/215339835-c82dc0eb-327e-4686-a4dc-e9a75f66ffe7.png"
height="400" style="max-width: 100%">

<img
src="https://user-images.githubusercontent.com/76530270/215339845-db92a97a-1af4-40a3-978d-413d2d811408.png"
height="400" style="max-width: 100%"> <img
src="https://user-images.githubusercontent.com/76530270/215339841-996c619b-dec7-4858-92a6-ae4e325a8791.png"
height="400" style="max-width: 100%">





<!-- Delete these section if this PR does not include UI-related
changes. -->
If your PR includes UI-related changes, then:
- Add screenshots for portrait/landscape for both a tablet & phone of
the before & after UI changes
- For the screenshots above, include both English and pseudo-localized
(RTL) screenshots (see [RTL
guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines))
- Add a video showing the full UX flow with a screen reader enabled (see
[accessibility
guide](https://github.com/oppia/oppia-android/wiki/Accessibility-(A11y)-Guide))
- Add a screenshot demonstrating that you ran affected Espresso tests
locally & that they're passing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant