Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App needs to be upgraded to SDK 31 in order to continue being able to be released on Play Store #4746

Closed
BenHenning opened this issue Nov 18, 2022 · 2 comments · Fixed by #4747
Closed

App needs to be upgraded to SDK 31 in order to continue being able to be released on Play Store #4746

BenHenning opened this issue Nov 18, 2022 · 2 comments · Fixed by #4747
Assignees
@BenHenning
Milestone
0.10 Release Bloc...

Comments

@BenHenning
Copy link
Member

No description provided.

@BenHenning BenHenning self-assigned this Nov 18, 2022
This was referenced Nov 18, 2022
Merged
Open
@BenHenning
Copy link
Member Author

So, upgrading the tests to SDK 31 is probably not reasonable due to it also affecting production code (see #4748 for details). We'll proceed with keeping tests on SDK 30 until we can properly move them over (#4748 is tracking this).

BenHenning added a commit that referenced this issue Nov 19, 2022
@BenHenning
Fix #4746: Update app to target SDK 31 (#4747)
7cb38ff 
## Explanation
Fixes #4746

This PR updates the app to target SDK 31 instead of 30 as this is now
required for continued Play Store releases.

Verification from the PR standpoint heavily relies on CI checks passing.
Beyond that, manual testing is needed to ensure no Android behavior
changes have led to regressions or new breakages.

This PR does NOT include updating Robolectric tests to run on SDK 31
since it's actually much harder than I had expected, and would lead to
potential production-affecting changes (as it would require updating
Kotlin & potentially other dependencies). #4748 is tracking fixing this
in the long-term.

## Essential Checklist
- [x] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [x] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [x] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [x] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).

## For UI-specific PRs only
N/A, mostly. While this is an infrastructure change, Android component
behaviors change with different target SDKs so it's quite possible for
there to be UI regressions or issues. Fortunately, most of the UI used
by the app is material and Jetpack (meaning it ships with the app and
will be mostly unaffected by target SDK changes).
BenHenning added a commit that referenced this issue Nov 19, 2022
@BenHenning
Fix #4746: Update app to target SDK 31 (#4747)
fdd2956 
## Explanation
Fixes #4746

This PR updates the app to target SDK 31 instead of 30 as this is now
required for continued Play Store releases.

Verification from the PR standpoint heavily relies on CI checks passing.
Beyond that, manual testing is needed to ensure no Android behavior
changes have led to regressions or new breakages.

This PR does NOT include updating Robolectric tests to run on SDK 31
since it's actually much harder than I had expected, and would lead to
potential production-affecting changes (as it would require updating
Kotlin & potentially other dependencies). #4748 is tracking fixing this
in the long-term.

## Essential Checklist
- [x] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [x] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [x] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [x] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).

## For UI-specific PRs only
N/A, mostly. While this is an infrastructure change, Android component
behaviors change with different target SDKs so it's quite possible for
there to be UI regressions or issues. Fortunately, most of the UI used
by the app is material and Jetpack (meaning it ships with the app and
will be mostly unaffected by target SDK changes).
JishnuGoyal added a commit to JishnuGoyal/oppia-android that referenced this issue Nov 20, 2022
@JishnuGoyal
Revert "Fix oppia#4746: Update app to target SDK 31 (oppia#4747)"
912c357 
This reverts commit 7cb38ff
BenHenning added a commit to BenHenning/oppia-android that referenced this issue Nov 21, 2022
@BenHenning
Revert "Revert "Fix oppia#4746: Update app to target SDK 31 (oppia#4747…
344e34e 
…)""

This reverts commit 912c357.
@BenHenning
Copy link
Member Author

Given that we were able to actually launch MR2, this can be considered complete. :)

@BenHenning BenHenning mentioned this issue Aug 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BenHenning BenHenning

Labels
None yet
Projects
None yet
Milestone
0.10 Release Blockers (Beta "Early Ac...
Development

Successfully merging a pull request may close this issue.

Fix #4746: Update app to target SDK 31 oppia/oppia-android
1 participant
@BenHenning