Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Continue Studying" texts keeps showing even when there is no next revision card #4645

Closed
JishnuGoyal opened this issue Oct 12, 2022 · 2 comments · Fixed by #4743
Closed

"Continue Studying" texts keeps showing even when there is no next revision card #4645

JishnuGoyal opened this issue Oct 12, 2022 · 2 comments · Fixed by #4743
Assignees
@JishnuGoyal

Comments

@JishnuGoyal
Copy link
Contributor

In the revision card fragment, the continue button header is shown even when there is no next/previous revision navigation card.
@JishnuGoyal JishnuGoyal self-assigned this Oct 12, 2022
@AbhaySota
Copy link

Please assign this to me. I think I can solve this.
@JishnuGoyal

@BenHenning
Copy link
Member

Thanks for your interest @AbhaySota. This issue is already assigned to @JishnuGoyal so you should pick another issue that's not yet assigned from among our starter issues.

@JishnuGoyal JishnuGoyal mentioned this issue Nov 17, 2022
Merged
6 tasks
BenHenning pushed a commit that referenced this issue Nov 17, 2022
@JishnuGoyal
Fix #4645: "Continue Studying" texts keeps showing even when there is…
3f553ec 
… no next revision card (#4743)

## Explanation
Fixes #4645 

This PR hides the "Continue Studying" text when there is only one
revision card in the list. It does so by adding a condition to the
visibility of this view inside the corresponding xml file. This PR is
backed up by unit tests.

## Essential Checklist
- [x] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [x] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [x] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [x] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).

## For UI-specific PRs only
If your PR includes UI-related changes, then:
- Add screenshots for portrait/landscape for both a tablet & phone of
the before & after UI changes
- For the screenshots above, include both English and pseudo-localized
(RTL) screenshots (see [RTL
guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines))
- Add a video showing the full UX flow with a screen reader enabled (see
[accessibility
guide](https://github.com/oppia/oppia-android/wiki/Accessibility-(A11y)-Guide))
- Add a screenshot demonstrating that you ran affected Espresso tests
locally & that they're passing

Before

![image](https://user-images.githubusercontent.com/64526117/202563107-452cbbf0-aa14-43cb-91c6-6b256061851f.png)

After

![image](https://user-images.githubusercontent.com/64526117/202565577-00b2299e-f92f-4dcf-9f0a-30830641e191.png)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JishnuGoyal JishnuGoyal

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@BenHenning @JishnuGoyal @AbhaySota