Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Android wiki to store source files in oppia-android repository #4622

Closed
U8NWXD opened this issue Sep 25, 2022 · 2 comments · Fixed by #4893
Closed

Migrate Android wiki to store source files in oppia-android repository #4622

U8NWXD opened this issue Sep 25, 2022 · 2 comments · Fixed by #4893
Assignees
Labels
Impact: Low Low perceived user impact (e.g. edge cases).

Comments

@U8NWXD
Copy link
Member

U8NWXD commented Sep 25, 2022

No description provided.

@U8NWXD
Copy link
Member Author

U8NWXD commented Sep 25, 2022

@BenHenning I don't have permission to edit the assignees of this issue. Since it's being handled by the welfare team, which spans the oppia-web and oppia-android projects, could you give me triage access so I can manage issues in oppia-android that are being handled by the welfare team?

@BenHenning
Copy link
Member

Apologies @U8NWXD I forgot to do that after our meeting--it should be done now. Please let me know if you run into any problems, though.

@U8NWXD U8NWXD added the Impact: Low Low perceived user impact (e.g. edge cases). label Oct 4, 2022
seanlip added a commit that referenced this issue Mar 17, 2023
<!-- READ ME FIRST: Please fill in the explanation section below and
check off every point from the Essential Checklist! -->
## Explanation
<!--
- Explain what your PR does. If this PR fixes an existing bug, please
include
- "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
issue
  - when this PR is merged.
  -->

- Fixes #4622
- The PR does the following: This PR moves the android wiki into the
oppia-andoird codebase allowing contributors to make PRs to the wiki
along with changes to the codebase itself. This PR also introduces a
GitHub Action (Runs when a PR is merged into develop and when a user
makes change to the wiki via the web interface) that copies the content
of the wiki folder along with the git history of the wiki folder and
deploys it to the oppia-android wiki repository.

The steps followed to achieve this wiki migration are present here: 
[Oppia Android Wiki Migration V2
(1).pdf](https://github.com/oppia/oppia-android/files/10921370/Oppia.Android.Wiki.Migration.V2.1.pdf)

### Note: Please ensure GitHub actions have write permissions. Please
follow these instructions to enable it:

[GrantingReadandWritePermissionsonGitHub_PDF.pdf](https://github.com/oppia/oppia-android/files/10919834/GrantingReadandWritePermissionsonGitHub_PDF.pdf)


## Essential Checklist
<!-- Please tick the relevant boxes by putting an "x" in them. -->
- [x] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [x] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [x] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [x] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).

## For UI-specific PRs only
<!-- Delete these section if this PR does not include UI-related
changes. -->
If your PR includes UI-related changes, then:
- Add screenshots for portrait/landscape for both a tablet & phone of
the before & after UI changes
- For the screenshots above, include both English and pseudo-localized
(RTL) screenshots (see [RTL
guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines))
- Add a video showing the full UX flow with a screen reader enabled (see
[accessibility
guide](https://github.com/oppia/oppia-android/wiki/Accessibility-(A11y)-Guide))
- Add a screenshot demonstrating that you ran affected Espresso tests
locally & that they're passing

---------

Co-authored-by: Rajat Talesra <[email protected]>
Co-authored-by: Ben Henning <[email protected]>
Co-authored-by: Akshay Nandwana <[email protected]>
Co-authored-by: Srikanth K B <[email protected]>
Co-authored-by: Jan <[email protected]>
Co-authored-by: Abhay Garg <[email protected]>
Co-authored-by: Arjun Gupta <[email protected]>
Co-authored-by: Sparsh Agrawal <[email protected]>
Co-authored-by: Farees Hussain <[email protected]>
Co-authored-by: Sarthak Agarwal <[email protected]>
Co-authored-by: Sean Lip <[email protected]>
Co-authored-by: Apoorv Srivastava <[email protected]>
Co-authored-by: Vinita Murthi <[email protected]>
Co-authored-by: Ankita Saxena <[email protected]>
Co-authored-by: Vojtěch Jelínek <[email protected]>
Co-authored-by: Ben Henning <[email protected]>
@github-project-automation github-project-automation bot moved this from In Progress to Done in Developer Workflow Team Mar 17, 2023
Uticodes pushed a commit to Uticodes/oppia-android that referenced this issue Mar 23, 2023
<!-- READ ME FIRST: Please fill in the explanation section below and
check off every point from the Essential Checklist! -->
## Explanation
<!--
- Explain what your PR does. If this PR fixes an existing bug, please
include
- "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
issue
  - when this PR is merged.
  -->

- Fixes oppia#4622
- The PR does the following: This PR moves the android wiki into the
oppia-andoird codebase allowing contributors to make PRs to the wiki
along with changes to the codebase itself. This PR also introduces a
GitHub Action (Runs when a PR is merged into develop and when a user
makes change to the wiki via the web interface) that copies the content
of the wiki folder along with the git history of the wiki folder and
deploys it to the oppia-android wiki repository.

The steps followed to achieve this wiki migration are present here: 
[Oppia Android Wiki Migration V2
(1).pdf](https://github.com/oppia/oppia-android/files/10921370/Oppia.Android.Wiki.Migration.V2.1.pdf)

### Note: Please ensure GitHub actions have write permissions. Please
follow these instructions to enable it:

[GrantingReadandWritePermissionsonGitHub_PDF.pdf](https://github.com/oppia/oppia-android/files/10919834/GrantingReadandWritePermissionsonGitHub_PDF.pdf)


## Essential Checklist
<!-- Please tick the relevant boxes by putting an "x" in them. -->
- [x] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [x] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [x] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [x] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).

## For UI-specific PRs only
<!-- Delete these section if this PR does not include UI-related
changes. -->
If your PR includes UI-related changes, then:
- Add screenshots for portrait/landscape for both a tablet & phone of
the before & after UI changes
- For the screenshots above, include both English and pseudo-localized
(RTL) screenshots (see [RTL
guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines))
- Add a video showing the full UX flow with a screen reader enabled (see
[accessibility
guide](https://github.com/oppia/oppia-android/wiki/Accessibility-(A11y)-Guide))
- Add a screenshot demonstrating that you ran affected Espresso tests
locally & that they're passing

---------

Co-authored-by: Rajat Talesra <[email protected]>
Co-authored-by: Ben Henning <[email protected]>
Co-authored-by: Akshay Nandwana <[email protected]>
Co-authored-by: Srikanth K B <[email protected]>
Co-authored-by: Jan <[email protected]>
Co-authored-by: Abhay Garg <[email protected]>
Co-authored-by: Arjun Gupta <[email protected]>
Co-authored-by: Sparsh Agrawal <[email protected]>
Co-authored-by: Farees Hussain <[email protected]>
Co-authored-by: Sarthak Agarwal <[email protected]>
Co-authored-by: Sean Lip <[email protected]>
Co-authored-by: Apoorv Srivastava <[email protected]>
Co-authored-by: Vinita Murthi <[email protected]>
Co-authored-by: Ankita Saxena <[email protected]>
Co-authored-by: Vojtěch Jelínek <[email protected]>
Co-authored-by: Ben Henning <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Impact: Low Low perceived user impact (e.g. edge cases).
Projects
Archived in project
4 participants