Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a gating parameter for configuration change #4469

Closed
vrajdesai78 opened this issue Jul 27, 2022 · 0 comments · Fixed by #4660
Closed

Create a gating parameter for configuration change #4469

vrajdesai78 opened this issue Jul 27, 2022 · 0 comments · Fixed by #4660
Assignees
@vrajdesai78
Labels
Impact: Low Low perceived user impact (e.g. edge cases). Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@vrajdesai78
Copy link
Contributor

Need to create a platform parameter to enable and disable configuration change for all InputInteractions. This is required to implement because to make configuration change fully working for all interactions it required 4-5 PRs. So, while doing this we need to put our changes behind the feature flag such that if that feature flag is enabled then only our changes will be reflected using a platform parameter.
@vrajdesai78 vrajdesai78 self-assigned this Jul 27, 2022
@Broppia Broppia added issue_type_infrastructure Impact: Low Low perceived user impact (e.g. edge cases). labels Jul 29, 2022
@BenHenning BenHenning changed the title Create a parameter gatting for configuration change Create a gating parameter for configuration change Sep 15, 2022
@BenHenning BenHenning added Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Z-ibt Temporary label for Ben to keep track of issues he's triaged. issue_user_developer labels Sep 15, 2022
@vrajdesai78 vrajdesai78 mentioned this issue Oct 17, 2022
Merged
6 tasks
BenHenning pushed a commit that referenced this issue Oct 18, 2022
@vrajdesai78
Fixes #4469: Create a gating parameter for configuration change (#4660)
2087258 
* Platform parameter added

* Renamed Platform Parameter

* Optimized Imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vrajdesai78 vrajdesai78

Labels
Impact: Low Low perceived user impact (e.g. edge cases). Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #4469: Create a gating parameter for configuration change vrajdesai78/oppia-android
4 participants
@seanlip @BenHenning @vrajdesai78 @Broppia