Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce CPU Usage performance metrics logging #4466

Closed
4 tasks done
Sarthak2601 opened this issue Jul 25, 2022 · 0 comments · Fixed by #4623
Closed
4 tasks done

Introduce CPU Usage performance metrics logging #4466

Sarthak2601 opened this issue Jul 25, 2022 · 0 comments · Fixed by #4623
Assignees
@Sarthak2601
Labels
Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Issue: Needs Break-down Indicates that an issue is too large and should be broken into smaller chunks. Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@Sarthak2601
Copy link
Contributor

Sarthak2601 commented Jul 25, 2022 •
edited
Loading

This issue tracks the implementation and logging of CPU Usage performance metrics.
Things to do for marking this issue as complete:

  • Correct proto definitions + comments.
  • Correct log creation support.
  • Correct logging flow.
  • Appropriate tests for cpu usage logging.
@Sarthak2601 Sarthak2601 added Type: Improvement Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. labels Jul 25, 2022
@Sarthak2601 Sarthak2601 self-assigned this Jul 25, 2022
@Broppia Broppia added Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). dev_team labels Jul 29, 2022
@Sarthak2601 Sarthak2601 mentioned this issue Sep 7, 2022
Merged
6 tasks
@BenHenning BenHenning added Z-ibt Temporary label for Ben to keep track of issues he's triaged. issue_user_developer Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Issue: Needs Break-down Indicates that an issue is too large and should be broken into smaller chunks. labels Sep 15, 2022
@Sarthak2601 Sarthak2601 mentioned this issue Sep 26, 2022
Merged
6 tasks
Sarthak2601 added a commit that referenced this issue Nov 1, 2022
@Sarthak2601
Fixes #4466: CPU Usage performance metrics logging (#4623)
929c142 
<!-- READ ME FIRST: Please fill in the explanation section below and
check off every point from the Essential Checklist! -->
## Explanation
<!--
- Explain what your PR does. If this PR fixes an existing bug, please
include
- "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
issue
  - when this PR is merged.
  -->
Fixes #4466: CPU Usage performance metrics logging. 

Introduces a CpuPerformanceSnapshotter that leverages the abilities of
an actor to sequentially log cpu usage. Cpu usage is logged after a
certain delay which is calculated on the basis of current Iconification
(foreground/background) of the app. This iconification is updated every
time the app changes state, i.e. goes from foreground to background or
vice-versa.

## Essential Checklist
<!-- Please tick the relevant boxes by putting an "x" in them. -->
- [x] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [x] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [x] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [x] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sarthak2601 Sarthak2601

Labels
Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Issue: Needs Break-down Indicates that an issue is too large and should be broken into smaller chunks. Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #4466: CPU Usage performance metrics logging oppia/oppia-android
4 participants
@seanlip @BenHenning @Sarthak2601 @Broppia