TextView & Toolbar color changes in Topic screen #4461
Assignees
Labels
Impact: Low
Low perceived user impact (e.g. edge cases).
Z-ibt
Temporary label for Ben to keep track of issues he's triaged.
Comments
|
Thanks @MihirShirgaonkar. I'm assuming that this is because the topic activity hasn't yet been migrated to support dark mode, but the toolbar and some headings have. Can you confirm @ayush0402 @rt4914? |
Broppia
added
issue_type_infrastructure
Impact: Low
BenHenning
added
issue_type_bug
Z-ibt
|
@MihirShirgaonkar @BenHenning This issue is now fixed in latest build.
|
|
Hmm the toolbar and tab colors seem different in dark mode @MohitGupta121. Shouldn't that be addressed before closing this? |
|
@BenHenning is actually in the develop, it's already according to the mockup. Actually, this issue is open in July but I implement dark mode for the topic fragment on September #4177 Also, I test it on my emulator and it's working fine for me:- That's why there is no need for this issue. And only Lesson Fragment Dark Mode is pending and its is already opens in #4624 |
BenHenning
moved this to Todo
in [Team] Core Learner and Mastery flows & UI Frontend - Android
rt4914
pushed a commit
that referenced
this issue
Dec 28, 2022
… Topic Revision, Revision Card, Story Activity, Resume Lesson (#4796) <!-- READ ME FIRST: Please fill in the explanation section below and check off every point from the Essential Checklist! --> ## Explanation Dark mode implementation - Topic Lessons, Topic Revision, Revision Card, Story Activity, Resume Lesson Fixes #4624 : Add dark mode support to Lesson Tab Fixes #4741 : Contrast issue in Continue Studying text on revision screen Fixes #4461 : TextView & Toolbar color changes in Topic screen <!-- - Explain what your PR does. If this PR fixes an existing bug, please include - "Fixes #bugnum:" in the explanation so that GitHub can auto-close the issue - when this PR is merged. --> ## Essential Checklist <!-- Please tick the relevant boxes by putting an "x" in them. --> - [x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".) - [ ] Any changes to [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets) files have their rationale included in the PR explanation. - [x] The PR follows the [style guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide). - [x] The PR does not contain any unnecessary code changes from Android Studio ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)). - [x] The PR is made from a branch that's **not** called "develop" and is up-to-date with "develop". - [x] The PR is **assigned** to the appropriate reviewers ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)). ## For UI-specific PRs only ### Topic Lessons <img src="https://user-images.githubusercontent.com/76530270/209782570-1b554b99-878d-4231-93ab-932a8392339f.png" height="400" style="max-width: 100%"> <img src="https://user-images.githubusercontent.com/76530270/209782638-1498b3bc-b34b-4f6e-b59c-5eb75585fdeb.png" height="400" style="max-width: 100%"> <img src="https://user-images.githubusercontent.com/76530270/209782928-aa3d63e0-77f6-454f-8a96-4ca0a79dcf2d.png" height="400" style="max-width: 100%"> <img src="https://user-images.githubusercontent.com/76530270/209783008-1e7431d5-4d38-4743-bae4-2efee687d962.png" height="400" style="max-width: 100%"> <img src="https://user-images.githubusercontent.com/76530270/209783226-440a9735-be10-4357-acd4-0a4fdffb2673.png" height="400" style="max-width: 100%"> <img src="https://user-images.githubusercontent.com/76530270/209783291-8f08c34a-7df4-4942-8a59-821946acb054.png" height="400" style="max-width: 100%"> <img src="https://user-images.githubusercontent.com/76530270/209783403-d18e5f83-9f25-4fd0-a789-05cffdccad72.png" height="400" style="max-width: 100%"> <img src="https://user-images.githubusercontent.com/76530270/209783480-47cea3e2-f25c-46b2-995b-39c624a5d4bd.png" height="400" style="max-width: 100%"> ### Topic Revision <img src="https://user-images.githubusercontent.com/76530270/208653330-185d700c-23d7-4387-8dad-0a37b410a99d.png" height="400" style="max-width: 100%"> <img src="https://user-images.githubusercontent.com/76530270/209088065-daf5ffd7-9c36-46a8-8d20-a8827204e2ca.png" height="400" style="max-width: 100%"> ### Revision Card <img src="https://user-images.githubusercontent.com/76530270/208653637-65a63055-59e0-4f6c-be4d-98e1a05cafb7.png" height="400" style="max-width: 100%"> <img src="https://user-images.githubusercontent.com/76530270/209088213-5a967191-a58f-4cfc-a6c4-611e67ff2dbe.png" height="400" style="max-width: 100%"> ### Story Activity <img src="https://user-images.githubusercontent.com/76530270/208654191-535ab103-4cb0-4e15-9aac-73c238da7e5a.png" height="400" style="max-width: 100%"> <img src="https://user-images.githubusercontent.com/76530270/208654157-245c22a6-ca76-4b6e-991c-045b0209a4f4.png" height="400" style="max-width: 100%"> <img src="https://user-images.githubusercontent.com/76530270/208654553-bbf2953f-e180-42fa-b6bd-2a0ec28911af.png" height="200" style="max-width: 100%"> <img src="https://user-images.githubusercontent.com/76530270/209088439-07b16179-ce9e-4cef-9f5f-4b2e2be9e691.png" height="200" style="max-width: 100%"> <img src="https://user-images.githubusercontent.com/76530270/209537829-dbd65e33-e1f2-40ff-8f70-c500e7d4883b.png" height="400" style="max-width: 100%"> <img src="https://user-images.githubusercontent.com/76530270/209784301-f024dbcd-3526-4068-a698-f1cae25dde9a.png" height="400" style="max-width: 100%"> <img src="https://user-images.githubusercontent.com/76530270/209538237-2409c6b1-e881-4e8c-8b20-25bce10868e3.png" height="400" style="max-width: 100%"> <img src="https://user-images.githubusercontent.com/76530270/209784484-4eb2ce01-721d-4364-91c2-d64510ff6da6.png" height="400" style="max-width: 100%"> ### Resume Lesson <img src="https://user-images.githubusercontent.com/76530270/208655056-2bf2a66b-a6eb-4ba3-b5ff-371f27427452.png" height="400" style="max-width: 100%"> <img src="https://user-images.githubusercontent.com/76530270/208655045-6ebaf554-bc42-47f9-b03e-3ad831ab78b1.png" height="400" style="max-width: 100%"> <!-- Delete these section if this PR does not include UI-related changes. --> If your PR includes UI-related changes, then: - Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes - For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see [RTL guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines)) - Add a video showing the full UX flow with a screen reader enabled (see [accessibility guide](https://github.com/oppia/oppia-android/wiki/Accessibility-(A11y)-Guide)) - Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing
github-project-automation
bot
moved this from Todo
to Done
in [Team] Core Learner and Mastery flows & UI Frontend - Android
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
TextView & Toolbar color changes in Topic screen in Info , Lesson and Practice fragments when switched from light mode to dark mode
To Reproduce
Steps to reproduce the behavior:
Open the app
Click on any lesson
Keep dark mode on
Environment Tested
The text was updated successfully, but these errors were encountered: