Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add domain level functionality for spotlights #4451

Closed
JishnuGoyal opened this issue Jul 22, 2022 · 0 comments · Fixed by #4498
Closed

Add domain level functionality for spotlights #4451

JishnuGoyal opened this issue Jul 22, 2022 · 0 comments · Fixed by #4498
Assignees
@JishnuGoyal
Labels
Impact: Low Low perceived user impact (e.g. edge cases). Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@JishnuGoyal
Copy link
Contributor

Is your feature request related to a problem? Please describe.
As a part of the GSoC project: Interactive Onboarding Flow which focusses on making the initial user experience more engaging and smooth, the plan is to introduce spotlights into the app.

Describe the solution you'd like
As an initial part of this plan, implement the domain level functionality for spotlights. This should cover all model classes and spotlight controllers necessary.
@JishnuGoyal JishnuGoyal self-assigned this Jul 27, 2022
@Broppia Broppia added issue_type_infrastructure Impact: Low Low perceived user impact (e.g. edge cases). and removed issue_type_infrastructure labels Jul 29, 2022
@BenHenning BenHenning added issue_type_infrastructure Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Z-ibt Temporary label for Ben to keep track of issues he's triaged. and removed issue_type_enhancement labels Sep 15, 2022
@JishnuGoyal JishnuGoyal mentioned this issue Sep 24, 2022
Merged
6 tasks
BenHenning pushed a commit that referenced this issue Sep 24, 2022
@JishnuGoyal
Fix #4451: Add domain level functionality for spotlights (#4498)
7653898 
* add enableSpotlightsUi platform parameter

* add spotlight proto

* add spotlight state controller

* small fixes

* lint

* suggested changes

* add bazel config for spotlight proto

* add bazel config for spotlight state controller

* add tests

* add code documentation

* remove extra eof and add some documentation

* remove spotlight_state_unspecified.

* add few tests

* lint

* Revert "remove spotlight_state_unspecified."

This reverts commit 71a5d07

* partial: Add tests

* complete: Add tests

* lint

* suggested changes in the latest review

* suggested changes in the last review

* remove dependencies from bazel build file

* lint

* commit requested changes

* lint

* changes acc to updates to the persistent cache store

* bazel config

* lint

* use spotlight_java_proto_lite

* lint

* bazel lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JishnuGoyal JishnuGoyal

Labels
Impact: Low Low perceived user impact (e.g. edge cases). Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #4451: Add domain level functionality for spotlights JishnuGoyal/oppia-android
4 participants
@seanlip @BenHenning @JishnuGoyal @Broppia