Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Talkback reader reads blank on empty resume lesson summary #4443

Closed
vrajdesai78 opened this issue Jul 22, 2022 · 0 comments · Fixed by #4444
Closed

Talkback reader reads blank on empty resume lesson summary #4443

vrajdesai78 opened this issue Jul 22, 2022 · 0 comments · Fixed by #4444
Assignees
@vrajdesai78
Labels
Impact: Low Low perceived user impact (e.g. edge cases). Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@vrajdesai78
Copy link
Contributor

Describe the bug
When we open the Ratios and Proportional reasoning story, the resume lesson summary is empty. So for such situation talkback reader is reading it blank instead of ignoring it.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Ratios and Proportional Reasoning'
  2. Click on any lesson
  3. Turn on the screen reader
  4. Navigate to all components on the screen using a screen reader.

Expected behavior
Whenever the resume lesson summary is blank or empty, the talkback reader should ignore it instead of reading it out blank.

Demonstration

blank-space.mp4

Environment

  • Device being used: Realme GT Master Edition
  • Android or SDK version (e.g. Android 5 or SDK 21): Android 12
  • App version (you can get this through system app settings or via the admin controls menu in-app): 1.0
@vrajdesai78 vrajdesai78 self-assigned this Jul 22, 2022
@vrajdesai78 vrajdesai78 mentioned this issue Jul 22, 2022
Merged
6 tasks
@Broppia Broppia added issue_type_bug Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Impact: Low Low perceived user impact (e.g. edge cases). labels Jul 29, 2022
rt4914 pushed a commit that referenced this issue Aug 3, 2022
@vrajdesai78
Fixes #4443: Talkback reader reads blank on empty resume lesson summa…
d8ab9e9 
…ry (#4444)

* Blank space removed by setting importantForAccessibility

* Handled edge case when description is empty

* updated other xml files and optimized code

* import optimized

* Changed logic

* changed logic to handle empty description and added tests

* removed unused import

* Optimized imports
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vrajdesai78 vrajdesai78

Labels
Impact: Low Low perceived user impact (e.g. edge cases). Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #4443: Talkback reader reads blank on empty resume lesson summary vrajdesai78/oppia-android
4 participants
@seanlip @BenHenning @vrajdesai78 @Broppia