Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change speaker icon to headphones icon #4439

Closed
JishnuGoyal opened this issue Jul 20, 2022 · 2 comments · Fixed by #4429
Closed

Change speaker icon to headphones icon #4439

JishnuGoyal opened this issue Jul 20, 2022 · 2 comments · Fixed by #4429
Assignees
@JishnuGoyal
Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@JishnuGoyal
Copy link
Contributor

Is your feature request related to a problem? Please describe.

According to the user reports, some users do not understand what the speaker button on the exploration screen does. Change it to a headphones button instead. Make sure that the button has both on and off states displayed correctly. This issue is a part of the GSoC Interactive Onboarding Flow project.
@JishnuGoyal
Copy link
Contributor Author

Please assign this to me @BenHenning

@BenHenning
Copy link
Member

Done @JishnuGoyal. FYI that you'll be able to self-assign once your onboarding is complete.

@JishnuGoyal JishnuGoyal mentioned this issue Jul 25, 2022
Merged
6 tasks
BenHenning pushed a commit that referenced this issue Jul 28, 2022
@JishnuGoyal
Fix #4439: Change speaker icon to headset icon (#4429)
3496373 
* change speaker icon to headset icon

* add headset-off icon and delete old icons

* use hex value instead of resource

* use hex value instead of resource because CI was failing

* refactor name of the drawable resource to match others

* reformat
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JishnuGoyal JishnuGoyal

Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #4439: Change speaker icon to headset icon JishnuGoyal/oppia-android
2 participants
@BenHenning @JishnuGoyal