Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add profile login counter #4438

Closed
JishnuGoyal opened this issue Jul 20, 2022 · 1 comment · Fixed by #4426
Closed

Add profile login counter #4438

JishnuGoyal opened this issue Jul 20, 2022 · 1 comment · Fixed by #4426
Assignees
@JishnuGoyal
Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@JishnuGoyal
Copy link
Contributor

Is your feature request related to a problem? Please describe.
This issue is a part of the GSoC project: Interactive Onboarding Flow.
We are planning to introduce certain onboarding flows in order to make the experience of a new user effortless in terms of having to decide which button to click next; and to make sure they are able to start learning quickly and take advantage of all the features that the app has to offer.

Describe the solution you'd like
To make sure we do not throw too much information at the user at once, we check how many times this user has logged into the app and then decide what to show to them, thus streamlining how much information is being given to them and when.
@JishnuGoyal
Copy link
Contributor Author

@BenHenning could you please assign this to me?

@BenHenning BenHenning mentioned this issue Jul 20, 2022
Merged
6 tasks
BenHenning pushed a commit that referenced this issue Jul 27, 2022
@JishnuGoyal
Fix #4438: Add profile login counter (#4426)
8dd1716 
* add number_of_logins field to profile proto

* add increment login count function

* add tests

* init number of logins to 0 when new profile is added

* shorten test name for lint issue

* shorten test name for lint issue

* use suggested approach for login count increment

* use suggested approach for login count increment + lint fix

* fix test name and logic as suggested

* modify test to check for login count = 2 after 2 logins

* nit

* lint

* rename test

* nit - add full stop
@JishnuGoyal JishnuGoyal mentioned this issue Aug 4, 2022
Merged
6 tasks
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JishnuGoyal JishnuGoyal

Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Developer Workflow & Infrastructure - Android
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #4438: Add profile login counter JishnuGoyal/oppia-android
2 participants
@BenHenning @JishnuGoyal