Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming EventLogger to AnalyticsEventLogger #4405

Closed
4 tasks
Sarthak2601 opened this issue Jun 27, 2022 · 0 comments · Fixed by #4694
Closed
4 tasks

Renaming EventLogger to AnalyticsEventLogger #4405

Sarthak2601 opened this issue Jun 27, 2022 · 0 comments · Fixed by #4694
Assignees
@adhiamboperes
Labels
Impact: Low Low perceived user impact (e.g. edge cases). Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Priority: Nice-to-have This work item is nice to have for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@Sarthak2601
Copy link
Contributor

Since we're moving towards more specific event loggers like the PerformanceMetricsEventLogger, the existing EventLogger has become too generic and hence, it must be refactored.

Potential checklist:

  • changes in all the production files where eventLogger is used,
  • changes in test files.
  • changes in dagger modules.
  • refactoring of fakeEventlogger to fakeAnalyticsEventLogger
@Sarthak2601 Sarthak2601 added Type: Improvement Priority: Nice-to-have This work item is nice to have for its milestone. labels Jun 27, 2022
@Sarthak2601 Sarthak2601 mentioned this issue Jun 27, 2022
Merged
6 tasks
@Broppia Broppia added the Impact: Low Low perceived user impact (e.g. edge cases). label Jul 6, 2022
@Akshatkamboj14 Akshatkamboj14 self-assigned this Aug 9, 2022
@Akshatkamboj14 Akshatkamboj14 mentioned this issue Aug 26, 2022
Closed
10 tasks
@Akshatkamboj14 Akshatkamboj14 mentioned this issue Sep 10, 2022
Closed
6 tasks
@Akshatkamboj14 Akshatkamboj14 removed their assignment Sep 13, 2022
@BenHenning BenHenning added Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Z-ibt Temporary label for Ben to keep track of issues he's triaged. issue_user_developer and removed good second issue labels Sep 14, 2022
@adhiamboperes adhiamboperes self-assigned this Nov 1, 2022
@adhiamboperes adhiamboperes mentioned this issue Nov 4, 2022
Merged
11 tasks
BenHenning added a commit that referenced this issue Nov 12, 2022
@adhiamboperes @Ryggs
@ma-za-kpe @BenHenning @vrajdesai78 @translatewiki
Fix #4405: Rename EventLogger to AnalyticsEventLogger (#4694)
6683c6d 
## Explanation
Fixes #4405: 
Refactoring EventLogger to AnalyticsEventLogger to make it more
specific, in line with refactoring other event loggers.

Changes to:
- [x] Application files: all implementations and usages
- [x] Dagger files
- [x] Rename associated test files, imports and variables
- [x] EventLogger Fakes and the DebugEventLogger

Did not make changes to the following, given they are already pretty
specific:
- [ ] PerformanceMetricsEventLogger

Refactored `scripts/assets/test_file_exemptions.textproto` to update the
new path of `DebugAnalyticsEventLogger`, `FirebaseAnalyticsEventLogger`
and `AnalyticsEventLogger` to exempt them from corresponding file
checks.
Refactored `file_content_validation_checks.textproto` to exempt
`FirebaseAnalyticsEventLogger` from prohibited _Locale_ use check.

## Essential Checklist
- [x] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [x] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [x] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [x] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).

Co-authored-by: Joshua Murigi <[email protected]>
Co-authored-by: MAZAKPE <[email protected]>
Co-authored-by: Ben Henning <[email protected]>
Co-authored-by: Vraj Desai <[email protected]>
Co-authored-by: translatewiki.net <[email protected]>
Repository owner moved this from Needs Triage to Done in [Team] Developer Workflow & Infrastructure - Android Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adhiamboperes adhiamboperes

Labels
Impact: Low Low perceived user impact (e.g. edge cases). Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Priority: Nice-to-have This work item is nice to have for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Developer Workflow & Infrastructure - Android
Archived in project
Milestone
No milestone
5 participants
@BenHenning @Sarthak2601 @adhiamboperes @Akshatkamboj14 @Broppia