Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[A11Y] Content description for close icon is not consistent. #4397

Closed
rt4914 opened this issue Jun 20, 2022 · 9 comments · Fixed by #4953
Closed

[A11Y] Content description for close icon is not consistent. #4397

rt4914 opened this issue Jun 20, 2022 · 9 comments · Fixed by #4953
Assignees
@XichengSpencer
Labels
bug End user-perceivable behaviors which are not desirable. good first issue This item is good for new contributors to make their pull request. Impact: Low Low perceived user impact (e.g. edge cases). Work: Low Solution is clear and broken into good-first-issue-sized chunks. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@rt4914
Copy link
Contributor

rt4914 commented Jun 20, 2022 •
edited by adhiamboperes
Loading

While checking this PR https://github.com/oppia/oppia-android/pull/4274/files I noticed two things:

  1. When we enable screen-reader for Concept Card the output for close-icon is Clicking on this will close the concept card, Button
  2. When we enable screen-reader for Hints & Solution the output for close-icon is Navigate Up, Button

This needs to be consistent across both screens.
https://github.com/oppia/oppia-android/wiki/Accessibility-A11y-Guide
@aayushimathur6 aayushimathur6 self-assigned this Jun 21, 2022
@Broppia Broppia added issue_type_bug Impact: Low Low perceived user impact (e.g. edge cases). labels Jul 7, 2022
@aayushimathur6 aayushimathur6 removed their assignment Sep 13, 2022
@BenHenning BenHenning added Z-ibt Temporary label for Ben to keep track of issues he's triaged. issue_user_learner labels Sep 15, 2022
@seanlip seanlip added bug End user-perceivable behaviors which are not desirable. and removed issue_user_learner labels Mar 29, 2023
@adhiamboperes adhiamboperes added the good first issue This item is good for new contributors to make their pull request. label Apr 18, 2023
@XichengSpencer
Copy link
Collaborator

Hi,
I am working on this and want to get some clarification here. Does the consistency mean that you want both of them to be"Navigate Up, Button" or "Clicking on this will close the concept card, Button"? I use talkback to test the app a bit, I found of most of the close buttons in the app will output "Navigate Up, Button". And I believe this is the default output value.
Looking for some suggestions here. Thank you

@XichengSpencer
Copy link
Collaborator

Just check the onboarding guideline, forget to @BenHenning

@adhiamboperes
Copy link
Collaborator

adhiamboperes commented Apr 19, 2023 •
edited
Loading

Hi,
I am working on this and want to get some clarification here. Does the consistency mean that you want both of them to be"Navigate Up, Button" or "Clicking on this will close the concept card, Button"? I use talkback to test the app a bit, I found of most of the close buttons in the app will output "Navigate Up, Button". And I believe this is the default output value.
Looking for some suggestions here. Thank you.

This sounds right.

Can you provide a brief description of how you'll solve this?

@XichengSpencer
Copy link
Collaborator

I can change the string value reference in the XML file to change the output. But I want to first get an idea of if I should change them all to be "Navigate Up, Button" or "Clicking on this will close the concept card"? This could determine which file I should get into. And after that I may have some follow up questions.
Thank you!

@adhiamboperes
Copy link
Collaborator

The description should be "Navigate up" if you change it to "Navigate up, Button", it would be read as "Navigate up, Button, Button"

@XichengSpencer
Copy link
Collaborator

Yeah, that makes sense to me. I was thinking if we use "Clicking on this will close the concept card" will be a bit redundant with the text on the nav menu. And if we want to customize this output, there are lots of works we have to apply on the other close buttons. Anyway, I will set it back to "Navigate up"
Thank you!

@XichengSpencer
Copy link
Collaborator

I follow the guide to create my new branch on top of develop and commit the change and try to push to the GitHub then I got denied. I have been struggle for a while to try different methods but haven't figure out. Can I get some help on this?

Here a screenshot of one of my attempts.
Screenshot 2023-04-19 130409

@XichengSpencer
Copy link
Collaborator

Here is the error message: "Permission to oppia/oppia-android.git denied to XichengSpencer. unable to access 'https://github.com/oppia/oppia-android.git/': The requested URL returned error: 403"

@MohitGupta121
Copy link
Member

@XichengSpencer please follow the instructions in this particular doc to setup and contribute to oppia-android.
If you have any query feel free to ask in github-discussion.

@XichengSpencer XichengSpencer mentioned this issue Apr 20, 2023
Merged
6 tasks
XichengSpencer added a commit to XichengSpencer/oppia-android that referenced this issue Apr 25, 2023
@XichengSpencer
Merge branch 'develop' into spencer-oppia#4397
edc924f
XichengSpencer added a commit to XichengSpencer/oppia-android that referenced this issue May 3, 2023
@XichengSpencer
Merge branch 'develop' into spencer-oppia#4397
5a5bb65
@adhiamboperes adhiamboperes added Work: Low Solution is clear and broken into good-first-issue-sized chunks. work label added labels May 4, 2023
XichengSpencer added a commit to XichengSpencer/oppia-android that referenced this issue May 9, 2023
@XichengSpencer
Merge branch 'develop' into spencer-oppia#4397
a433a75
BenHenning added a commit to XichengSpencer/oppia-android that referenced this issue May 16, 2023
@BenHenning
Merge branch 'develop' into spencer-oppia#4397
a856e6e
BenHenning added a commit that referenced this issue May 16, 2023
@XichengSpencer @BenHenning
Fix #4397, #4923: Change the closing button description for consisten…
da80fab 
…cy & gender neutral profile image (#4953)

Fixes #4397: The closing button on the nav bar of concept card activity
had inconsistent voice output, it is changed to "navigate up" for
consistency.
Fixes #4923: "Have outline person as default gender-neutral image"
 

## Essential Checklist
<!-- Please tick the relevant boxes by putting an "x" in them. -->
- [x] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [x] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [x] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [x] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).


## For UI-specific PRs only
If your PR includes UI-related changes, then:
- Add screenshots for portrait/landscape for both a tablet & phone of
the before & after UI changes

![Screenshot 2023-05-09
120944](https://github.com/oppia/oppia-android/assets/74568012/7487abae-ad58-4807-8731-5a057d681afa)
![Screenshot 2023-05-09
120920](https://github.com/oppia/oppia-android/assets/74568012/0c583328-9f6c-4dcb-89f1-3903008290a5)
![Screenshot 2023-05-09
120932](https://github.com/oppia/oppia-android/assets/74568012/d6c9bf8f-f917-4e30-a7ae-169c9e10a07b)
![Screenshot 2023-05-09
134648](https://github.com/oppia/oppia-android/assets/74568012/ed5327d8-8886-4b3c-8f16-c29919560ef0)
![Screenshot 2023-05-09
134632](https://github.com/oppia/oppia-android/assets/74568012/00a5173d-6f7b-4599-b95e-71fcfacc33ff)


- For the screenshots above, include both English and pseudo-localized
(RTL) screenshots (see [RTL guide]


![Screenshot 2023-05-09
135514](https://github.com/oppia/oppia-android/assets/74568012/c93c128a-7040-4cc1-9193-dc86edce3c68)
![Screenshot 2023-05-09
135209](https://github.com/oppia/oppia-android/assets/74568012/3cee8597-1230-478a-8e8c-1bdff8ac1650)
![Screenshot 2023-05-09
135235](https://github.com/oppia/oppia-android/assets/74568012/367b6e81-98c5-41ff-9c5d-8563d18385bf)
![Screenshot 2023-05-09
135319](https://github.com/oppia/oppia-android/assets/74568012/b915a26c-9e93-433d-8604-e79d401be19b)

---------

Co-authored-by: Ben Henning <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@XichengSpencer XichengSpencer

Labels
bug End user-perceivable behaviors which are not desirable. good first issue This item is good for new contributors to make their pull request. Impact: Low Low perceived user impact (e.g. edge cases). Work: Low Solution is clear and broken into good-first-issue-sized chunks. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
8 participants
@rt4914 @seanlip @BenHenning @adhiamboperes @XichengSpencer @MohitGupta121 @aayushimathur6 @Broppia