Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For few of the questions in explorations the hints provided are numbered randomly #4343

Closed
KolliAnitha opened this issue May 5, 2022 · 5 comments · Fixed by #4630
Closed

For few of the questions in explorations the hints provided are numbered randomly #4343

KolliAnitha opened this issue May 5, 2022 · 5 comments · Fixed by #4630
Assignees
@Ryggs
Labels
Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Milestone
0.10 Release Bloc...

Comments

@KolliAnitha
Copy link

KolliAnitha commented May 5, 2022 •
edited
Loading

Describe the bug
For few of the questions in explorations the hints provided are numbered randomly

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Ratios'
  2. Click on 'Multiplication'
  3. Click on Continue to get to the question page 'how many petals there are on the flowers'
  4. Wait for hint

*Expected behavior
Hint 1 should be displayed instead of hint 6

Actual Result:
Hint 6 is seen

Screenshot_2022-04-29-18-21-47-60_943a62cb4c6fb83e010e1c2e82766a17.jpg

Environment
Device name: One plus Nord2 5G
Android version : Android 11
App version : 0.7-alpha-d1b2827517
@BenHenning
Copy link
Member

Ah, I was aware of this but I don't think we had an issue to track it--thanks @KolliAnitha.

The problem here is that we're currently use the content ID of the hint as its header which is incorrect. We should instead be numbering the headers in a localization-friendly way.

I think this is a good starter issue material, but marking it as a 'second issue' since the APIs for localization can be a bit tricky to learn.

@Broppia Broppia added issue_type_bug Impact: Low Low perceived user impact (e.g. edge cases). labels May 31, 2022
@BenHenning
Copy link
Member

For searching context, this issue was found in 0.7-alpha (MR4).

@BenHenning BenHenning added this to the Beta MR1 milestone Jun 11, 2022
@BenHenning BenHenning modified the milestones: Beta MR1, Beta MR2 Jun 11, 2022
@BenHenning BenHenning added Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Z-ibt Temporary label for Ben to keep track of issues he's triaged. issue_user_learner and removed good second issue Impact: Low Low perceived user impact (e.g. edge cases). labels Sep 14, 2022
@BenHenning BenHenning removed this from the Beta MR2 milestone Sep 16, 2022
@rt4914 rt4914 moved this from Needs Triage to In Progress: Being implemented in [Team] Core Learner and Mastery flows & UI Frontend - Android Sep 20, 2022
@Ryggs
Copy link
Contributor

Ryggs commented Sep 21, 2022 •
edited
Loading

@BenHenning ,

WhatsApp Image 2022-09-21 at 20 00 06

  • Opened the whole folder in vs code. Search globally “content_id”:”hint_15”, and “content_id”:”hint_6”.
  • To show you that some hint content_id’s are not orderly numbered, some start from 6 then 7 or 14, 15. So maybe this could just be a numbering issue in the JSON files. As shown in the images below.

hint7

hint16

WhatsApp Image 2022-09-14 at 15 46 14 (2)

WhatsApp Image 2022-09-21 at 20 01 00

I cannot seem to find the hint text in the issue in the release assets folder.
Perform a search in vs code and type in petal or the text in the photo, assigned with this issue,
you will notice its absence.

Suggestion: This issue may just be fine the way it is, or the hint numbering in the JSON files is needed.

@BenHenning
Copy link
Member

@Ryggs this issue isn't fine the way it is because learners will encounter hint numbers that don't make sense to them. This comes from the fact that we're using the content IDs today for the hint name header, but content IDs are never meant to be shown to the user (so there's nothing to actually change in the lessons themselves). We should, instead, be displaying the hint number based on which hint it is, rather than based on its content ID.

@Ryggs Ryggs mentioned this issue Oct 4, 2022
Merged
6 tasks
BenHenning pushed a commit that referenced this issue Oct 10, 2022
@Ryggs @ma-za-kpe
Fix #4343: Fixes Explorations hints being numbered randomly (#4630)
18814f5 
* fix: explorations hints numbered randomly

* remove the nullable property part from OppiaLocale on the toHumanReadable mehtod

* change hint name to hint_list_item_number

* fix: name hint strng, remove nullanle factor from the toHumanReadableString including removing the .toString() method, compute index property inline, add three tests

* fix: revert formating changes, test wit non english number localization, test for values larger than 10,000

* fix: optimise imports

* fix: change test to hebrew locale

* fix: test toHumanReadableString to take hebrew number locale

* fix: test toHumanReadableString to take EgyptArabic number locale

* fix: test toHumanReadableString to take EgyptArabic number locale in displayLoacleImpl

* fix: remove unused code and verify test success with suugested fix

* Fix: revert back to hint_1, to test the breaking tests

* Fix: revert back to hint_1, in test_exp_id_2.json file (gradle)

* Fix: revert back to hint_6 in textproto

* Fix: add hint_6 to translation mappings

Co-authored-by: MAZAKPE <[email protected]>
Repository owner moved this from In Progress: Being implemented to Done in [Team] Core Learner and Mastery flows & UI Frontend - Android Oct 10, 2022
@KolliAnitha
Copy link
Author

KolliAnitha commented Nov 14, 2022 •
edited
Loading

Verified in beta build 0.10-beta-5e64fae55e. Observed for couple of questions the hints are numbered orderly
Screenshot (Nov 14, 2022 2_38_05 PM)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ryggs Ryggs

Labels
Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
0.10 Release Blockers (Beta "Early Ac...
Development

Successfully merging a pull request may close this issue.

Fix #4343: Fixes Explorations hints being numbered randomly Ryggs/oppia-android
5 participants
@BenHenning @Ryggs @bhaktideshmukh @KolliAnitha @Broppia