Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add performance metrics logging during critical user journeys #4340

Closed
Sarthak2601 opened this issue May 1, 2022 · 0 comments · Fixed by #4462
Closed

Add performance metrics logging during critical user journeys #4340

Sarthak2601 opened this issue May 1, 2022 · 0 comments · Fixed by #4462
Assignees
Labels
Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Issue: Needs Break-down Indicates that an issue is too large and should be broken into smaller chunks. Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@Sarthak2601
Copy link
Contributor

This issue tracks the implementation of metric logging during critical user journeys in the application.

@Sarthak2601 Sarthak2601 self-assigned this May 1, 2022
@Broppia Broppia added issue_type_dev_initiated Impact: Low Low perceived user impact (e.g. edge cases). labels May 31, 2022
@Sarthak2601 Sarthak2601 linked a pull request Jul 23, 2022 that will close this issue
6 tasks
@BenHenning BenHenning added Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Issue: Needs Break-down Indicates that an issue is too large and should be broken into smaller chunks. Z-ibt Temporary label for Ben to keep track of issues he's triaged. issue_user_developer and removed Impact: Low Low perceived user impact (e.g. edge cases). labels Sep 15, 2022
Sarthak2601 added a commit that referenced this issue Sep 20, 2022
* base setup.

* name correction.

* nits.

* nits.

* storage comment

* pss comment

* network usage comment.

* network usage comment - part 2.

* metric addition in proto definitions.

* metricLog --> loggableMetric

* proto definitions in oppiaLogger

* wording update for transmission

* dependency/api updates.

* nits.

* metric controller and oppiaLogger

* nits

* logger-controller pattern, single utils

* nits

* comments

* log uploading support

* nits

* nits

* performance metric event logger nits.

* nits.

* logger reinstated.

* nits

* deleting unused interfaces.

* log generator to metric log scheduler

* nits

* nits -- kdoc, code placing, readability

* nits -- kdoc, code placing, readability

* worker functions to schedule logging, renaming

* nits.

* clearing up build errors.

* nits.

* fixing build errors.

* removal of dependency from oppiaLogger and basing the entire implementation on Logger-Controller

* performanceMetricController tests + fakeLogger

* fakeLogger tests

* nits

* tests for the new logger.

* tests for the worker + renaming of package to logScheduler

* tests for work manager initializer

* initial base setup for utils test

* nits

* nits

* nit

* worker and initializer tests

* event bundle creator tests

* module tests

* nits

* performanceMetricsUtils tests

* nits

* renamed logUpload to logReport + nits

* nits

* nits

* review updates.

* nit

* review updates - 2

* isAppInForeground revamp

* isAppInForeground revamp

* nits

* domain tests repair

* app tests repair

* nits.

* nits.

* nits.

* nits.

* nit

* test update.

* test update.

* nit

* todo issue number update -- static check

* initial draft logging

* comments.

* nits.

* utils test + nits

* utils test + nits

* nits

* test rearrangement

* nits

* test fixes.

* impl removal

* impl removal

* introduction of activity lifecycle callbacks for latency logging and active ui monitoring.

* nit

* tests for new observer

* worker tests

* nits

* nits

* nits

* nits

* nits

* nits

* test fixes.

* memory and storage tier updates

* memory and storage tier updates

* updates.

* nits

* test file exemptions refactor due to file renaming.

* additional tests, nit fixes.

* delta calculation, nits.

* currentActivity update.

* nits

* nit

* proto update.

* activity manager shadow and assessor test

* nit

* nit

* observer updates and test fixes

* nits.

* shadow traffic stats + assessor test fix.

* custom shadow tests

* module deps

* tests

* nits

* metricLogScheduler refactor and test

* exemption removal

* nits

* updates.

* updates.

* nit.

* variable nits + parameterized test exemption

* app component dependencies.

* nits

* logging module bazel build, config module creation

* testing robolectric bazel module update

* domain bazel build fixes

* working oppia bazel build

* nits.

* nits.

* nit for bazel building

* addition of test file for module

* bazel tests fixes

* more fixes.

* reformatting

* nits

* nits

* deps added

* dep fix

* deps fix

* deps fix

* nit

* nits

* nits

* review changes.

* nits

* gradle test fix.

* bazel oppia build

* utitlity bazel building.

* test fixes -- renaming.

* deps addition

* bazel correction

* previous merge correction

* all activities with attached proto enums.

* nit

* nits.

* tests for checking screenName in intents.

* nits

* updates.

* nits

* bazel update.

* nit

* post review updates

* nits

* nits + backgrounding change

* extractCurrentAppScreenName change

* test file correction

* nits

* nits.

* activity lifecycle tests update.

* nits.

* null case for screen name + tests for decorator

* nits

* exhaustive when + test fixes.

* nits

* nit

* test fix

* nit

* bazel fix

* tests fix

* regex checks for verifying screen names in activities + tests

* bazel test fix

* nits

* regex tests

* nits

* todo addition

* bazel file formatting

* nits.

* additional todo update.

* parameterized tests for analytics name

* nits

* background dispatcher for logging

* nits

* nits

* nits

* bazel fixes.

* regex fixes.

* nits

* nit

* nit

* nit

* nits

* nit

* nit fixes.

* regex fixes

* nits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Issue: Needs Break-down Indicates that an issue is too large and should be broken into smaller chunks. Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants