Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dark mode support to MarkChaptersCompletedActivity, MarkStoriesCompletedActivity, MarkTopicsCompletedActivity and ProfilePictureActivity #4192

Closed
ayush0402 opened this issue Feb 14, 2022 · 7 comments · Fixed by #4442
Closed

Add dark mode support to MarkChaptersCompletedActivity, MarkStoriesCompletedActivity, MarkTopicsCompletedActivity and ProfilePictureActivity #4192

ayush0402 opened this issue Feb 14, 2022 · 7 comments · Fixed by #4442
Assignees
@bhaktideshmukh
Labels
Impact: Low Low perceived user impact (e.g. edge cases). Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@ayush0402
Copy link
Contributor

ayush0402 commented Feb 14, 2022 •
edited
Loading

Add dark mode support to MarkChaptersCompletedActivity, MarkStoriesCompletedActivity, MarkTopicsCompletedActivity and ProfilePictureActivity

Go through this wiki to get started.
@UvrajSB
Copy link

UvrajSB commented Mar 29, 2022

Can you assign this issue to me, please

@ayush0402
Copy link
Contributor Author

@UvrajSB Assigned.

@UvrajSB
Copy link

UvrajSB commented Mar 31, 2022

For the text color of checkboxes in different states ( selected, enabled but not selected, disabled), I cant find any fit from palette.
Should I create references in palette like "color_palette_selected_check_box_text_color"
Is this approach fine?

@UvrajSB
Copy link

UvrajSB commented Apr 1, 2022 •
edited
Loading

For the disabled checkbox, the text has been assigned black color with alpha = 0.38
but it is better if we assign it some color code according to the designs it should be "color_def_oppia_grayish_black" but that is hardly visible on the background.
There is no color code in color_defs that matches the requirement.

I suggest to use some lighter shade of gray like #5CB8B8B8

@Broppia Broppia added issue_type_feature Impact: Low Low perceived user impact (e.g. edge cases). labels Jun 13, 2022
@ritece
Copy link

ritece commented Jul 9, 2022

is this issue available? I'd like to start working on this.

@UvrajSB
Copy link

UvrajSB commented Jul 9, 2022

is this issue available? I'd like to start working on this.

Yeah you can go ahead

@bhaktideshmukh
Copy link
Contributor

is this issue available? I'd like to start working on this.

Are you still working on it?

@bhaktideshmukh bhaktideshmukh self-assigned this Jul 19, 2022
@bhaktideshmukh bhaktideshmukh mentioned this issue Jul 22, 2022
Merged
6 tasks
rt4914 pushed a commit that referenced this issue Jul 27, 2022
@bhaktideshmukh
Fixes #4192 : Added dark mode support to MarkChaptersCompletedActivit…
f446fe8 
…y, MarkStoriesCompletedActivity and MarkTopicsCompletedActivity (#4442)

* dark_mode

* added mark_completed_text color
Repository owner moved this from Needs Triage to Done in [Team] Core Learner and Mastery flows & UI Frontend - Android Jul 27, 2022
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bhaktideshmukh bhaktideshmukh

Labels
Impact: Low Low perceived user impact (e.g. edge cases). Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
6 participants
@ritece @BenHenning @UvrajSB @ayush0402 @bhaktideshmukh @Broppia