Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove colors_migrating.xml post dark mode implementation. #4147

Closed
ayush0402 opened this issue Feb 1, 2022 · 3 comments · Fixed by #4876
Closed

Remove colors_migrating.xml post dark mode implementation. #4147

ayush0402 opened this issue Feb 1, 2022 · 3 comments · Fixed by #4876
Assignees
@MohitGupta121
Labels
Impact: Low Low perceived user impact (e.g. edge cases). Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@ayush0402
Copy link
Contributor

Currently colors_migrating.xml contains color declarations which are supposed to be in color_defs.xml but have not yet been renamed yet to have actual color name instead of names linked to their use and components. This is a temporary measure to make sure other 4 color files follows the convention decided for them.

colors_migrating.xml should be removed once dark mode is implemented to most screens via color_defs.xml.

Reference : #4032
@Broppia Broppia added issue_type_infrastructure Impact: Low Low perceived user impact (e.g. edge cases). labels Jun 13, 2022
@BenHenning BenHenning added Z-ibt Temporary label for Ben to keep track of issues he's triaged. issue_user_developer labels Sep 15, 2022
@MohitGupta121
Copy link
Member

MohitGupta121 commented Sep 18, 2022 •
edited
Loading

@rt4914 or @BenHenning Can I take this issue or wait till all dark mode complete ?

@MohitGupta121

This comment was marked as off-topic.

Sign in to view
@MohitGupta121
Copy link
Member

MohitGupta121 commented Feb 13, 2023 •
edited
Loading

@BenHenning @rt4914 I got some help from Sean, and now I am planning to use avatar_background_colors directly from color_defs only in ProfileChooserFragmentPresenter.kt because avatar_background_colors getting in random basis in ProfileChooserFragment (whose background is already dark in color for both light/dark mode, so it's not effecting the user) as this only avatar_background_colors blocking me to make PR. But now get unblocked by Sean.

But @BenHenning if you have any other suggestions then please share.
Thanks.

@MohitGupta121 MohitGupta121 mentioned this issue Feb 13, 2023
Merged
6 tasks
rt4914 pushed a commit that referenced this issue Feb 20, 2023
@MohitGupta121
Fixed #4147 : Remove colors_migrating.xml post dark mode implementati…
c7349c3 
…on. (#4876)

<!-- READ ME FIRST: Please fill in the explanation section below and
check off every point from the Essential Checklist! -->
## Explanation

Fixed #4147 : Remove colors_migrating.xml post dark mode implementation.

<!--
- Explain what your PR does. If this PR fixes an existing bug, please
include
- "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
issue
  - when this PR is merged.
  -->

## Essential Checklist
<!-- Please tick the relevant boxes by putting an "x" in them. -->
- [x] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [x] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [x] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [x] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).

## For UI-specific PRs only
<!-- Delete these section if this PR does not include UI-related
changes. -->
If your PR includes UI-related changes, then:
- Add screenshots for portrait/landscape for both a tablet & phone of
the before & after UI changes
- For the screenshots above, include both English and pseudo-localized
(RTL) screenshots (see [RTL
guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines))
- Add a video showing the full UX flow with a screen reader enabled (see
[accessibility
guide](https://github.com/oppia/oppia-android/wiki/Accessibility-(A11y)-Guide))
- Add a screenshot demonstrating that you ran affected Espresso tests
locally & that they're passing
supreme96 pushed a commit to supreme96/oppia-android that referenced this issue Feb 24, 2023
@MohitGupta121 @supreme96
Fixed oppia#4147 : Remove colors_migrating.xml post dark mode impleme…
7626f48 
…ntation. (oppia#4876)

<!-- READ ME FIRST: Please fill in the explanation section below and
check off every point from the Essential Checklist! -->
## Explanation

Fixed oppia#4147 : Remove colors_migrating.xml post dark mode implementation.

<!--
- Explain what your PR does. If this PR fixes an existing bug, please
include
- "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
issue
  - when this PR is merged.
  -->

## Essential Checklist
<!-- Please tick the relevant boxes by putting an "x" in them. -->
- [x] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [x] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [x] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [x] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).

## For UI-specific PRs only
<!-- Delete these section if this PR does not include UI-related
changes. -->
If your PR includes UI-related changes, then:
- Add screenshots for portrait/landscape for both a tablet & phone of
the before & after UI changes
- For the screenshots above, include both English and pseudo-localized
(RTL) screenshots (see [RTL
guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines))
- Add a video showing the full UX flow with a screen reader enabled (see
[accessibility
guide](https://github.com/oppia/oppia-android/wiki/Accessibility-(A11y)-Guide))
- Add a screenshot demonstrating that you ran affected Espresso tests
locally & that they're passing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MohitGupta121 MohitGupta121

Labels
Impact: Low Low perceived user impact (e.g. edge cases). Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed #4147 : Remove colors_migrating.xml post dark mode implementation.
5 participants
@rt4914 @BenHenning @ayush0402 @MohitGupta121 @Broppia