Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Revision Tab Icon #4086

Closed
srushtirk opened this issue Jan 7, 2022 · 15 comments · Fixed by #4635
Closed

Change Revision Tab Icon #4086

srushtirk opened this issue Jan 7, 2022 · 15 comments · Fixed by #4635
Assignees
Labels
Impact: Low Low perceived user impact (e.g. edge cases). Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@srushtirk
Copy link

Is your feature request related to a problem? Please describe.
The icon, when seen without the labels, do not match to real world representation of ‘revision’ and is misleading as found during user studies. Students often opened the revision tab when asked to start learning.

Current revision tab icon:
Screen Shot 2022-01-07 at 3 47 16 PM

Describe the solution you'd like
Update revision icon to below:
Screen Shot 2022-01-07 at 3 47 51 PM

Describe alternatives you've considered
Alternatives considered in this doc: @https://docs.google.com/a/google.com/document/d/1oD8LTH71BBsXxn5R1F8To3EsV786w0q-EQFcb4hRiik/edit

Additional context
Add any other context or screenshots about the feature request here.

cc: @mschanteltc

@srushtirk srushtirk added this to the Beta MR1 milestone Jan 7, 2022
@srushtirk srushtirk added Found-in: Alpha MR3 Priority: Essential This work item must be completed for its milestone. labels Jan 7, 2022
@BenHenning
Copy link
Member

Is the proposed icon a material icon @srushtirk? Or, is there a material icon alternative that we can use?

@om-khandade
Copy link

No it is not a material icon. An alternative could be "Format List Bulleted".

@srushtirk
Copy link
Author

@om-khandade Won't the users will get confused between lessons and revision tab is we use 'format list bulleted' icon for revision? I believe this won't solve the current user pain point of not being able to distinguish between lessons and revision tab intuitively.

@srushtirk
Copy link
Author

Revision_icon

@BenHenning here is the material icon.

@BenHenning
Copy link
Member

For searching context, this issue was found in 0.6-alpha (MR3).

@pratyaksh1610
Copy link
Contributor

pratyaksh1610 commented Aug 25, 2022

@BenHenning I would like to work on this issue .
Since it is inactive.
Can I be assigned ?
Thanks.

@BenHenning
Copy link
Member

@pratyaksh1610 this is available to work on--happy to assign it to you.

@BenHenning
Copy link
Member

Actually scratch that, we need to verify that the new icon will solve the original concern for the issue. @seanlip it would be nice to have product feedback on this.

@BenHenning BenHenning assigned seanlip and unassigned om-khandade Aug 30, 2022
@seanlip
Copy link
Member

seanlip commented Aug 30, 2022

I just chatted with @om-khandade, and here are some updates to what is currently in this thread:

I'll post a follow-up to "what we should do" in the next comment.

@seanlip
Copy link
Member

seanlip commented Aug 30, 2022

Based on a discussion between @om-khandade and I, here is what we propose:

@BenHenning Could you please advise on the desirability of using icons from the standard Material set? If other icons are also OK, could you please let us know what constraints they will need to satisfy (e.g. file format, size, etc.)? Thanks.

@seanlip seanlip assigned BenHenning and unassigned seanlip Aug 30, 2022
@BenHenning
Copy link
Member

@seanlip a Material icon isn't strictly needed (though it can simplify things slightly since we can pull it in through third-party dependencies rather than including our own icon). I'm happy to go with our own icon so long as it's a vector graphic and matches the aesthetic of other Material icons used in the app. Besides that, we should go with whatever icon works best with learners.

@BenHenning BenHenning assigned seanlip and unassigned BenHenning Aug 30, 2022
@seanlip
Copy link
Member

seanlip commented Aug 31, 2022

Thanks @BenHenning! Sounds good -- assigning to @om-khandade to supply the icon so that it can be replaced.

@seanlip seanlip assigned om-khandade and unassigned seanlip Aug 31, 2022
@om-khandade
Copy link

Group 1(5)
Here is the icon to be used.

@seanlip
Copy link
Member

seanlip commented Sep 2, 2022

Thanks, @om-khandade!

@pratyaksh1610 -- I think you can now go ahead with this, if you'd like to. Thanks!

@seanlip seanlip assigned pratyaksh1610 and unassigned om-khandade Sep 2, 2022
@pratyaksh1610
Copy link
Contributor

@seanlip Thankyou for assigning me, I am working on it.

@BenHenning BenHenning added issue_type_bug Z-ibt Temporary label for Ben to keep track of issues he's triaged. and removed issue_type_infrastructure labels Sep 15, 2022
@BenHenning BenHenning removed this from the Beta MR2 milestone Sep 16, 2022
@rt4914 rt4914 moved this from Needs Triage to In Progress: Being implemented in [Team] Core Learner and Mastery flows & UI Frontend - Android Sep 20, 2022
BenHenning pushed a commit that referenced this issue Oct 6, 2022
* changed revision tab icon

* reformat code and replaced the icon in the existing file
Repository owner moved this from In Progress: Being implemented to Done in [Team] Core Learner and Mastery flows & UI Frontend - Android Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Impact: Low Low perceived user impact (e.g. edge cases). Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Development

Successfully merging a pull request may close this issue.

6 participants