Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[A11Y Advanced] Lessons tab flow needs to be improved #3896

Closed
rt4914 opened this issue Oct 6, 2021 · 4 comments · Fixed by #4441
Closed

[A11Y Advanced] Lessons tab flow needs to be improved #3896

rt4914 opened this issue Oct 6, 2021 · 4 comments · Fixed by #4441
Assignees
@vrajdesai78
Labels
Impact: Low Low perceived user impact (e.g. edge cases). Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@rt4914
Copy link
Contributor

rt4914 commented Oct 6, 2021

Lessons tab flow needs to be improved. Current experience is shown below:

bad_flow.mp4
@rt4914 rt4914 added Type: Improvement Priority: Essential This work item must be completed for its milestone. labels Oct 6, 2021
@rt4914 rt4914 added this to the Beta milestone Oct 6, 2021
@BenHenning
Copy link
Member

BenHenning commented Oct 6, 2021 •
edited
Loading

To clarify, is this an advanced test failure?

@rt4914 rt4914 changed the title [A11Y] Lessons tab flow needs to be improved [A11Y Advanced] Lessons tab flow needs to be improved Oct 6, 2021
@rt4914
Copy link
Contributor Author

rt4914 commented Oct 6, 2021

Yes. This is an advanced test.

@BenHenning BenHenning linked a pull request Oct 6, 2021 that will close this issue
(Should fix) #3789: Fix flaky test retry mechanism for Bazel CI #3908
Merged
6 tasks
@BenHenning BenHenning removed a link to a pull request Oct 6, 2021
(Should fix) #3789: Fix flaky test retry mechanism for Bazel CI #3908
Merged
6 tasks
@bkaur-bkj
Copy link
Contributor

@rt4914 sir I would like to discuss on this issue, what is meant by advanced test failure? and do we have any expected flow which would be better than this or we need to figure it out

@rt4914
Copy link
Contributor Author

rt4914 commented Dec 13, 2021

@bkaur-bkj Actually this issue is part of [A11Y] Advanced and currently we are focused on [A11Y] Basic and based on that I suggest you pick up something from that.
For clarification part, the video shows that each and every UI item is browsable(can be visited) but the flow is incorrect and experience is bad. The aim of this issue is to somehow make the experience better. The best experience would be to simulate the behaviour of any regular user.

@rishidyno rishidyno reopened this Feb 8, 2022
@vrajdesai78 vrajdesai78 mentioned this issue Jul 21, 2022
Merged
6 tasks
@Broppia Broppia added issue_type_infrastructure Impact: Low Low perceived user impact (e.g. edge cases). and removed issue_type_bug labels Jul 29, 2022
rt4914 pushed a commit that referenced this issue Aug 13, 2022
@vrajdesai78
Fixes #3896: Improve flow of lessons tab (#4441)
db57738 
* Removed repetitive content description

* Updated topic_lessons_story_summary.xml for landscape

* Fixed klint issues

* KDoc added

* Removed changed onclick

* Updated tests

* Updated testcases

* Drop-down-icon clicklistener added

* klint issue fixed

* Optimized code for lessons flow

* Added tests

* Klint issue fixed

* Nit changes

* Updated logic and testcases

* fixed error

* Rerun ci checks
Repository owner moved this from Needs Triage to Done in [Team] Core Learner and Mastery flows & UI Frontend - Android Aug 13, 2022
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vrajdesai78 vrajdesai78

Labels
Impact: Low Low perceived user impact (e.g. edge cases). Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #3896: Improve flow of lessons tab vrajdesai78/oppia-android
7 participants
@rt4914 @seanlip @BenHenning @vrajdesai78 @bkaur-bkj @rishidyno @Broppia