Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add temporary offline support for audio & image streaming #386

Closed
Tracked by #3610
BenHenning opened this issue Nov 16, 2019 · 1 comment · Fixed by #399
Closed
Tracked by #3610

Add temporary offline support for audio & image streaming #386

BenHenning opened this issue Nov 16, 2019 · 1 comment · Fixed by #399
Assignees
@BenHenning
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@BenHenning
Copy link
Member

BenHenning commented Nov 16, 2019 •
edited
Loading

We need to include the audio assets for the supported fractions & ratio lessons with the APK binary and support local streaming rather than only remote streaming to be able to demonstrate offline support.
@BenHenning BenHenning added Workstream: Finalize Prototype pt1 (15-20 Nov) Priority: Essential This work item must be completed for its milestone. labels Nov 16, 2019
@BenHenning BenHenning self-assigned this Nov 16, 2019
@BenHenning BenHenning changed the title Add temporary offline support for audio streaming Add temporary offline support for audio & imagestreaming Nov 17, 2019
@BenHenning BenHenning changed the title Add temporary offline support for audio & imagestreaming Add temporary offline support for audio & image streaming Nov 17, 2019
@BenHenning
Copy link
Member Author

We also need this for images if we want to properly play lessons in full with wifi disabled.

@BenHenning BenHenning mentioned this issue Nov 18, 2019
Merged
BenHenning added a commit that referenced this issue Nov 20, 2019
@BenHenning
Fix #386: Add support for local caching of audio & image assets (#399)
b8100ad 
* Ensured progress, thumbnails, and stats are consistent.

This change ensures that completed progress is consistent and correct
everywhere for fractions and ratios topics.

It also ensures that there are thumbnails defined for chapters, and that
all thumbnails are consistent regardless of which screen topics,
stories, or chapters are viewed from.

It updates the reported lesson count to be correct.

* Use a different color for the fractions topic vs. ratios.

* Remove dev comment.

* Compute actual JSON disk size requirement for each topic.

* Introduce AssetRepository to prefetch JSON files, and support offline
caching for audio files.

* Introduce custom local image caching.

* Add module to disable local asset caching by default, and ensure tests
pass.

* Post-merge fix.
This was referenced Jul 29, 2021
Merged
Merged
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BenHenning BenHenning

Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #386: Add support for local caching of audio & image assets oppia/oppia-android
2 participants
@seanlip @BenHenning