Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Past answers should be collapsed #379

Closed
BenHenning opened this issue Nov 16, 2019 · 0 comments · Fixed by #412
Closed

Past answers should be collapsed #379

BenHenning opened this issue Nov 16, 2019 · 0 comments · Fixed by #412
Assignees
@BenHenning
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@BenHenning
Copy link
Member

We should only show the most recently submitted answer, and otherwise collapse the list of N-1 prior answer & feedbacks that can be expanded by the user to see the whole conversation.
@BenHenning BenHenning added Workstream: Finalize Prototype pt1 (15-20 Nov) Priority: Essential This work item must be completed for its milestone. labels Nov 16, 2019
@BenHenning BenHenning self-assigned this Nov 16, 2019
@BenHenning BenHenning mentioned this issue Nov 19, 2019
Merged
BenHenning added a commit that referenced this issue Nov 26, 2019
@BenHenning
Fix #379: Collapse past wrong answers (#412)
ebf9e46 
* Refactor the builder for BindableAdapter.

This splits the adapter into two: one for single-type recycler views,
and another for multi-type recycler views. The latter has also been
updated to require an enum for typing rather than an integer to ensure
type safety. Per existing usages, we may want to switch this to a KClass
in the future since it seems like we typically convert from class type
to enum, anyway.

* Display the original submitted answer text instead of a read-only
version of the interaction with a normalized version of the answer.

* Add test for updated exploration progress controller.

* Remove isReadOnly and previously submitted InteractionObject since
UserAnswer and submitted answer item replaces this mechanism.

* Introduce support for collapsing past answers.

* Post-merge fix.

* Address reviewer comments.
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BenHenning BenHenning

Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #379: Collapse past wrong answers oppia/oppia-android
1 participant
@BenHenning