Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[A11Y] Add accessibility support for ImageRegionSelectionInteraction [Blocked: oppia/#9924] #3712

Closed
FareesHussain opened this issue Aug 20, 2021 · 7 comments · Fixed by #4497 or #4543
Closed

[A11Y] Add accessibility support for ImageRegionSelectionInteraction [Blocked: oppia/#9924] #3712

FareesHussain opened this issue Aug 20, 2021 · 7 comments · Fixed by #4497 or #4543
Assignees
@vrajdesai78
Labels
Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@FareesHussain
Copy link
Contributor

ImageRegions of ImageRegionSelectionInteraction doesn't have accessibility support.

Additional information other than the exact answer need to be added as content description for each image region.

oppia/oppia#9924 For details
@FareesHussain FareesHussain mentioned this issue Aug 20, 2021
Merged
8 tasks
@BenHenning
Copy link
Member

/cc @rt4914 per a11y project.

@vrajdesai78 vrajdesai78 self-assigned this Feb 25, 2022
@vrajdesai78 vrajdesai78 mentioned this issue Mar 10, 2022
Closed
6 tasks
@BenHenning BenHenning changed the title Add accessibility support for ImageRegionSelectionInteraction Add accessibility support for ImageRegionSelectionInteraction [Blocked: oppia/#9924] Mar 24, 2022
@vrajdesai78
Copy link
Contributor

Blocked on #9924

@rt4914 rt4914 changed the title Add accessibility support for ImageRegionSelectionInteraction [Blocked: oppia/#9924] [A11Y] Add accessibility support for ImageRegionSelectionInteraction [Blocked: oppia/#9924] May 11, 2022
@Broppia Broppia added issue_type_bug Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). labels Jun 13, 2022
@vrajdesai78 vrajdesai78 self-assigned this Aug 6, 2022
@vrajdesai78 vrajdesai78 mentioned this issue Aug 6, 2022
Merged
6 tasks
BenHenning pushed a commit that referenced this issue Aug 29, 2022
@vrajdesai78
Fixes #3712: Add accessibility support for ImageRegionSelectionIntera…
36e7661 
…ction (#4497)

* content description added

* tests updated

* KDoc and comment added

* textproto updated

* kdoc comment updated

* @param changed to @Property in kdoc
Repository owner moved this from Needs Triage to Done in [Team] Core Learner and Mastery flows & UI Frontend - Android Aug 29, 2022
@github-actions github-actions bot reopened this Aug 29, 2022
@github-actions
Copy link

The issue is reopened because of the following unresolved TODOs:

oppia-android/instrumentation/src/javatests/org/oppia/android/instrumentation/player/ExplorationPlayerTest.kt

Line 61 in 36e7661

// TODO(#3712): Use content description to fetch the image region.

@BenHenning
Copy link
Member

Looks like a TODO wasn't removed @vrajdesai78.

@vrajdesai78
Copy link
Contributor

@BenHenning will I have to create a new pull request to remove this TODO ?

@BenHenning
Copy link
Member

In order to close the issue, yes @vrajdesai78. Since it's trivial, you could add it to another ongoing PR to avoid creating a new PR (either approach is fine, and is up to you).

@vrajdesai78 vrajdesai78 mentioned this issue Aug 30, 2022
Merged
6 tasks
@vrajdesai78
Copy link
Contributor

@BenHenning created new PR #4543

@BenHenning BenHenning added Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Z-ibt Temporary label for Ben to keep track of issues he's triaged. issue_user_learner labels Sep 15, 2022
BenHenning pushed a commit that referenced this issue Oct 5, 2022
@vrajdesai78
Fixes #3712: Add accessibility support for ImageRegionSelectionIntera…
23795b9 
…ction [Removed Todo followed by #4497] (#4543)

* content description added

* tests updated

* KDoc and comment added

* textproto updated

* kdoc comment updated

* @param changed to @Property in kdoc

* TODO removed

* Updated issue number in ToDo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vrajdesai78 vrajdesai78

Labels
Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
6 participants
@rt4914 @seanlip @BenHenning @vrajdesai78 @FareesHussain @Broppia