Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate using finish instead of intent #3641

Closed
2 tasks
Sparsh1212 opened this issue Aug 4, 2021 · 4 comments · Fixed by #5557
Closed
2 tasks

Investigate using finish instead of intent #3641

Sparsh1212 opened this issue Aug 4, 2021 · 4 comments · Fixed by #5557
Assignees
@theayushyadav11
Labels
enhancement End user-perceivable enhancements. good first issue This item is good for new contributors to make their pull request. Impact: Low Low perceived user impact (e.g. edge cases). Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Work: Low Solution is clear and broken into good-first-issue-sized chunks. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@Sparsh1212
Copy link
Contributor

Sparsh1212 commented Aug 4, 2021 •
edited by adhiamboperes
Loading

Currently, we need to start intent for ProfileChooserActivity to get an update. We need to investigate on using finish instead as the live data bug is fixed.
@Broppia Broppia added issue_type_infrastructure Impact: Low Low perceived user impact (e.g. edge cases). labels Jul 7, 2022
@BenHenning BenHenning added Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Z-ibt Temporary label for Ben to keep track of issues he's triaged. issue_user_developer labels Sep 15, 2022
@seanlip seanlip added bug End user-perceivable behaviors which are not desirable. and removed issue_type_infrastructure labels Mar 28, 2023
@seanlip seanlip added enhancement End user-perceivable enhancements. and removed bug End user-perceivable behaviors which are not desirable. Type: Improvement labels Jun 16, 2023
@adhiamboperes adhiamboperes added the Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. label Aug 10, 2023
@adhiamboperes adhiamboperes added the good first issue This item is good for new contributors to make their pull request. label Oct 28, 2023
@rishav2404
Copy link

I want to work on this issue. Please assign this to me.

@adhiamboperes
Copy link
Collaborator

I want to work on this issue. Please assign this to me.

Hi @rishav2404, please give an overview of your proposed solution

@adhiamboperes adhiamboperes added Work: Low Solution is clear and broken into good-first-issue-sized chunks. and removed Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. labels May 17, 2024
@adhiamboperes adhiamboperes mentioned this issue Jul 17, 2024
Merged
6 tasks
@theayushyadav11
Copy link
Collaborator

I want to work on this issue,plz assign it to me.

@adhiamboperes
Copy link
Collaborator

@theayushyadav11, please feel free to create a PR.

@theayushyadav11 theayushyadav11 mentioned this issue Oct 21, 2024
Merged
6 tasks
subhajitxyz pushed a commit to subhajitxyz/oppia-android that referenced this issue Nov 19, 2024
@theayushyadav11 @subhajitxyz
Fixes oppia#3641 Use finish() instead of intent for smoother navigati…
9d4edf0 
…on (oppia#5557)

## Description:
- Fixes oppia#3641  
This PR simplifies the navigation logic in `AddProfileActivity` and
documents the reasoning behind not using `finish()` in
`ExitProfileDialogFragment`.

### Changes Made:
- **AddProfileActivity:**  
- Replaced the use of `Intent` with `FLAG_ACTIVITY_CLEAR_TOP` by calling
`finish()`.
- With the live data bug resolved, the activity stack can now be managed
more cleanly without requiring a new intent.

  **Benefits:**  
  - Avoids unnecessary activity recreation.  
  - Improves navigation efficiency and reduces overhead.  

- **ExitProfileDialogFragment:**  
- Retained the use of an `Intent` to navigate to
`ProfileChooserActivity` instead of switching to `finish()`.
  - **Reason:**  
- `ProfileChooserActivity` is not directly below the current activity in
the stack.
- If `finish()` were used, the app would incorrectly navigate to
`PinPasswordActivity`, resulting in undesirable behavior.

### Testing:
1. Verified that `AddProfileActivity` correctly navigates back to
`ProfileChooserActivity` using `finish()` without activity recreation.
2. Confirmed that `ExitProfileDialogFragment` behaves as expected,
retaining the correct navigation path through `Intent` to
`ProfileChooserActivity`.

### Summary:
This PR ensures cleaner navigation for `AddProfileActivity` by using
`finish()`, while maintaining correct behavior in
`ExitProfileDialogFragment` by continuing to use an intent-based
approach. This makes the app more efficient while preserving user
experience.

### Video Demo as everything is working fine.

https://github.com/user-attachments/assets/fb383845-5672-4236-8618-a87583cbbba0



## Essential Checklist
- [x] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [x] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [x] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [x] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@theayushyadav11 theayushyadav11

Labels
enhancement End user-perceivable enhancements. good first issue This item is good for new contributors to make their pull request. Impact: Low Low perceived user impact (e.g. edge cases). Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Work: Low Solution is clear and broken into good-first-issue-sized chunks. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #3641 Use finish() instead of intent for smoother navigation theayushyadav11/oppia-android
7 participants
@seanlip @BenHenning @Sparsh1212 @adhiamboperes @Broppia @rishav2404 @theayushyadav11