Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge all_topics.xml into single xml file #3459

Closed
rt4914 opened this issue Jul 12, 2021 · 3 comments · Fixed by #3519
Closed

Merge all_topics.xml into single xml file #3459

rt4914 opened this issue Jul 12, 2021 · 3 comments · Fixed by #3519
Assignees
@deepanshu731
Labels
good first issue This item is good for new contributors to make their pull request. Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. Priority: Nice-to-have This work item is nice to have for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@rt4914
Copy link
Contributor

rt4914 commented Jul 12, 2021

Currently there are 4 versions of all_topics.xml file merge it into single xml file.

We can use https://text-compare.com/ to compare two versions of this file and for all the differences we can create variables in dimens.xml file and use it accordingly.

Note: In PR, make sure you add before and after screenshot of mobile-portrait, mobile-landscape, tablet-portrait and tablet-landscape for comparison and make sure that there is not difference between before and after UI.
@rt4914 rt4914 added Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. Priority: Nice-to-have This work item is nice to have for its milestone. good first issue This item is good for new contributors to make their pull request. labels Jul 12, 2021
@rt4914 rt4914 added this to the Backlog milestone Jul 12, 2021
@deepanshu731
Copy link
Contributor

I want to work on this issue

@anandwana001
Copy link
Contributor

Hi @deepanshu731
Any update on this issue? Are you finding any difficulty in making the Pull Request?

@deepanshu731
Copy link
Contributor

@anandwana001 I have created a PR. plz review the PR

@deepanshu731 deepanshu731 mentioned this issue Jul 25, 2021
Merged
rt4914 pushed a commit that referenced this issue Jul 28, 2021
@deepanshu731
Fix #3459: Merge all topics into single XML file (#3519)
04bc03f 
* dimens updated and xml merged into one

* revert unwanted changes

* reverted unwanted changes

* revert unwanted change

* requested changes done

* Update all_topics.xml

* Update dimens.xml

* Update dimens.xml

* Update dimens.xml
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deepanshu731 deepanshu731

Labels
good first issue This item is good for new contributors to make their pull request. Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. Priority: Nice-to-have This work item is nice to have for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #3459: Merge all topics into single XML file deepanshu731/oppia-android
5 participants
@rt4914 @seanlip @BenHenning @anandwana001 @deepanshu731