Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[A11y] Use alt-with-value from <oppia-noninteractive-image> in RichText #3432

Closed
rt4914 opened this issue Jul 7, 2021 · 2 comments · Fixed by #3433 or #4669
Closed

[A11y] Use alt-with-value from <oppia-noninteractive-image> in RichText #3432

rt4914 opened this issue Jul 7, 2021 · 2 comments · Fixed by #3433 or #4669
Assignees
@vrajdesai78
Labels
Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Priority: Essential This work item must be completed for its milestone. Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@rt4914
Copy link
Contributor

rt4914 commented Jul 7, 2021 •
edited
Loading

Currently oppia-noninteractive-image is used to render images in RichText.
We should use its attribute alt-with-value as content description which will be readable by screen readers as an alternative to images.
@rt4914 rt4914 added this to the Beta milestone Jul 7, 2021
@rt4914 rt4914 added Priority: Essential This work item must be completed for its milestone. Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. Where: Exploration player labels Jul 7, 2021
@rt4914 rt4914 self-assigned this Jul 7, 2021
@rt4914 rt4914 mentioned this issue Jul 7, 2021
Merged
8 tasks
rt4914 added a commit that referenced this issue Jul 12, 2021
@rt4914
Fix #3432: [A11y] Content description for rich text based images (#3433)
7505dd5 
* Implemented content description for rich text

* Nit fix

* Nit fix

* Nit fix

Co-authored-by: Rajat Talesra <[email protected]>
anandwana001 added a commit that referenced this issue Sep 6, 2021
@anandwana001
Revert "Fix #3432: [A11y] Content description for rich text based ima…
b1ad50e 
…ges (#3433)"

This reverts commit 7505dd5.
@anandwana001 anandwana001 reopened this Sep 6, 2021
@anandwana001 anandwana001 reopened this Sep 10, 2021
@rt4914 rt4914 self-assigned this Sep 11, 2021
@rt4914 rt4914 removed their assignment Jan 18, 2022
@rt4914
Copy link
Contributor Author

rt4914 commented Jan 18, 2022

More information about this issue:
It was solved on in this PR #3433
but later on we identified one issue because of this PR #3765

In short, the code mentioned in #3433 does work well but raises the issue mentioned in #3765 .While solving this issue you can check code from #3433 for reference and make sure that it does work for #3765 also.

@TheSwarnim
Copy link
Contributor

Hi @BenHenning and @rt4914, I would like to work on this issue. Please assign it to me

@rt4914 rt4914 changed the title [A11y] Use alt-with-value from <oppia-interactive-image> in RichText [A11y] Use alt-with-value from <oppia-noninteractive-image> in RichText Feb 22, 2022
@Broppia Broppia added issue_type_infrastructure Impact: Low Low perceived user impact (e.g. edge cases). labels Jul 14, 2022
@vrajdesai78 vrajdesai78 self-assigned this Jul 23, 2022
@rt4914 rt4914 mentioned this issue Sep 1, 2022
Closed
@BenHenning BenHenning added issue_type_bug Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Z-ibt Temporary label for Ben to keep track of issues he's triaged. and removed issue_type_infrastructure Impact: Low Low perceived user impact (e.g. edge cases). labels Sep 15, 2022
@BenHenning BenHenning removed this from the Beta milestone Sep 16, 2022
@vrajdesai78 vrajdesai78 mentioned this issue Oct 20, 2022
Merged
6 tasks
BenHenning added a commit that referenced this issue Nov 7, 2022
@vrajdesai78 @BenHenning
Fixes #3432: Use alt-with-value from <oppia-noninteractive-image> in …
fbf58d7 
…RichText (#4669)

## Explanation
Fixes #3432: Created a `handleContentDescription` function in
CustomHtmlContentHandler which is further override in ImageTagHandler.
With current approach, I am setting up text (content description text
from alt-with-value) to image.

## Essential Checklist
<!-- Please tick the relevant boxes by putting an "x" in them. -->
- [x] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [x] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [x] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [x] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).

### Demo Video



https://user-images.githubusercontent.com/43074241/199427651-4e3b571c-d8a9-4f02-b05f-943cd6f8a5a0.mp4

Co-authored-by: Ben Henning <[email protected]>
@adhiamboperes adhiamboperes mentioned this issue Jun 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vrajdesai78 vrajdesai78

Labels
Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Priority: Essential This work item must be completed for its milestone. Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
7 participants
@rt4914 @seanlip @BenHenning @anandwana001 @vrajdesai78 @TheSwarnim @Broppia