Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce a demo PlatformParameter (Compile Time) #3401

Closed
Arjupta opened this issue Jul 2, 2021 · 0 comments · Fixed by #3441
Closed

Introduce a demo PlatformParameter (Compile Time) #3401

Arjupta opened this issue Jul 2, 2021 · 0 comments · Fixed by #3441
Assignees
@Arjupta
Labels
Priority: Essential This work item must be completed for its milestone. Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@Arjupta
Copy link
Contributor

Arjupta commented Jul 2, 2021

Introduce a test PlatformParameter to verify the Compile time Flag architecture.

SplashScreenToast

Target PR date: 6 July 2021
Target completion date: 11 July 2021
@Arjupta Arjupta added Where: Infrastructure Priority: Essential This work item must be completed for its milestone. Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. labels Jul 2, 2021
@Arjupta Arjupta added this to the GSoC 2021.4: Milestone 1 milestone Jul 2, 2021
@Arjupta Arjupta self-assigned this Jul 2, 2021
@Arjupta Arjupta mentioned this issue Jul 4, 2021
Closed
8 tasks
@Arjupta Arjupta mentioned this issue Jul 8, 2021
Merged
8 tasks
jcqli pushed a commit that referenced this issue Jul 8, 2021
@Arjupta
Fix #3401: Introduced SplashScreenWelcomeMsg PlatformParameter (#3441)
96e6131 
* Introduced new SplashTestActivity to have an implementation of Compile Time PlatformParameter

* Add PlatformParameterModule to all TestApplicationComponents + removing Target annotation from Qualifiers

* Correcting Lint issues

* KDoc Changes

* KDoc changes + Refactoring functions

* Nit comment related changes

* Further KDoc changes

* Rearrange Activity in Manifest

* Changing function names in Presenter and coverted KDoc to comment

* Reverted the Prod SplashActivityPresenter and made Second Test Case for PlatformParameterIntegrationTest is made to run on Espresso only
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Arjupta Arjupta

Labels
Priority: Essential This work item must be completed for its milestone. Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Developer Workflow & Infrastructure - Android
Archived in project
Milestone
No milestone
2 participants
@BenHenning @Arjupta