Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert welcome.xml into single layout file #3359

Closed
rt4914 opened this issue Jun 22, 2021 · 3 comments · Fixed by #3368
Closed

Convert welcome.xml into single layout file #3359

rt4914 opened this issue Jun 22, 2021 · 3 comments · Fixed by #3368
Assignees
@TheSwarnim
Labels
good first issue This item is good for new contributors to make their pull request. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@rt4914
Copy link
Contributor

rt4914 commented Jun 22, 2021

Currently welcome.xml has 4 different qualifier files but instead we can convert this into one single file.

Make sure that it does not affect the UI for any screen. To check this correct take before and after screenshots of home screen for mobile-portrait, mobile-landscape, tablet-portrait, tablet-landscape and they should look exactly same as before.
@rt4914 rt4914 added this to the Backlog milestone Jun 22, 2021
@rt4914 rt4914 added good first issue This item is good for new contributors to make their pull request. Type: Improvement labels Jun 22, 2021
@rt4914 rt4914 assigned rt4914 and unassigned rt4914 Jun 22, 2021
@rt4914
Copy link
Contributor Author

rt4914 commented Jun 22, 2021

@TheSwarnim PTAL

@TheSwarnim
Copy link
Contributor

Hello @rt4914, please assign this issue to me, sir. I'm working on it...

TheSwarnim pushed a commit to TheSwarnim/oppia-android that referenced this issue Jun 23, 2021
Fix #oppia#3359 Convert welcome.xml into single layout file
da7eccd
@TheSwarnim TheSwarnim mentioned this issue Jun 23, 2021
Merged
8 tasks
@TheSwarnim
Copy link
Contributor

Hello @prayutsu and @rt4914 I've added a pull request, please review it.
Thanks

rt4914 pushed a commit that referenced this issue Jun 29, 2021
@TheSwarnim
Fix #3359: Convert welcome.xml into single layout file pull request f…
8dcd8de 
…or issue (#3368)

* Fix ##3359 Convert welcome.xml into single layout file

* Created new dimens value for home welcome outer padding

* reverting back to previous commits in .idea/misc.xml .idea/runConfigurations.xml build.gradle

* changing files .idea/misc.xml .idea/runConfigurations.xml build.gradle to as per develop branch

* Resolving some commit issues in .idea/misc.xml .idea/runConfigurations.xml build.gradle

* Revert back to prevoius changes in .idea/misc.xml
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheSwarnim TheSwarnim

Labels
good first issue This item is good for new contributors to make their pull request. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
None yet
Milestone
No milestone
4 participants
@rt4914 @seanlip @BenHenning @TheSwarnim