Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High fi StoryActivity Inactive Card #2756

Closed
rt4914 opened this issue Feb 23, 2021 · 7 comments · Fixed by #2948
Closed

High fi StoryActivity Inactive Card #2756

rt4914 opened this issue Feb 23, 2021 · 7 comments · Fixed by #2948
Assignees
Labels
Priority: Nice-to-have This work item is nice to have for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@rt4914
Copy link
Contributor

rt4914 commented Feb 23, 2021

The mock for inactive card in StoryActivity has been updated to include clickable text to start the previous chapter.

https://xd.adobe.com/view/e8aa4198-3940-47f9-514a-f41cc54457f6-9e9b/screen/5abb0ace-19ee-48b8-8154-919154f924d2/

@rt4914 rt4914 added this to the Global Availability milestone Feb 23, 2021
@rt4914 rt4914 added Priority: Nice-to-have This work item is nice to have for its milestone. Status: Not started labels Feb 23, 2021
@yashraj-01
Copy link
Contributor

@rt4914 I would like to work on this issue. Please assign this to me.

@rt4914
Copy link
Contributor Author

rt4914 commented Feb 24, 2021

I am assigning you this and un-assigning you from #2324 as that issue will need more context.

@yashraj-01
Copy link
Contributor

@rt4914 in the mock, this feature works on clicking on the entire card. So, do I need to make the whole card clickable or just the text?

@rt4914
Copy link
Contributor Author

rt4914 commented Feb 24, 2021

@rt4914 in the mock, this feature works on clicking on the entire card. So, do I need to make the whole card clickable or just the text?

Only the text. @yashraj-iitr . For reference you can check how Concept Cards work in our app.

@yashraj-01
Copy link
Contributor

@rt4914 I explored the app, and I think that I need to update the logic in the function onExplorationClicked() inside StoryChapterSummaryViewModel.kt.

Please tell me if I am thinking right. If not, then please guide me where to look. Thanks.

@rt4914
Copy link
Contributor Author

rt4914 commented Mar 1, 2021

@rt4914 I explored the app, and I think that I need to update the logic in the function onExplorationClicked() inside StoryChapterSummaryViewModel.kt.

Please tell me if I am thinking right. If not, then please guide me where to look. Thanks.

@yashraj-iitr Actually thats not correct.

  1. You don't have to update the onExplorationClicked logic because for inactive/locked cards this function won't work.
  2. Also, as per UI, you only need to make the text clickable and that too not entirely, just the Chapter 2: The Meaning of “Equal Parts” which is in green color.

This is similar to Concept Card that we use in Exploration.
You can open concept card by following steps mentioned here: #1637 (comment)

@yashraj-01
Copy link
Contributor

As per #1637 (comment) , I think that using clickableSpan would make part of the text clickable. But I couldn't figure out where to implement this.

@rt4914 could you guide me further or may be provide a reference?

yashraj-01 pushed a commit to yashraj-01/oppia-android that referenced this issue Mar 19, 2021
rt4914 pushed a commit that referenced this issue Mar 30, 2021
* Fix #2756: clickable text summary for inactive cards

* fixed text cutoff

* changed function to openClickableSpan from QuestionPlayerActivityTest

* added inline comments

* created consts for string lengths
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Nice-to-have This work item is nice to have for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
3 participants