Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[A11y] Options Language Screen #2631

Closed
2 tasks
rt4914 opened this issue Feb 5, 2021 · 6 comments · Fixed by #2784
Closed
2 tasks

[A11y] Options Language Screen #2631

rt4914 opened this issue Feb 5, 2021 · 6 comments · Fixed by #2784
Assignees
@abhinav12k
Labels
good first issue This item is good for new contributors to make their pull request. Priority: Essential This work item must be completed for its milestone. Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@rt4914
Copy link
Contributor

rt4914 commented Feb 5, 2021 •
edited
Loading

Current Output

current_options_language.mp4

Issues Identified

  • The talkback reads this screen as Oppia at start, instead it should be either Default Audio Language or App Language
  • When any particular item is selected the output should be : French, checked, 2 of 4 or French, 2 of 4, checked and checkbox should bot be selected separately. This will reduce one step for the learner.
    Note: To understand the above issue(s) completely, it is recommended that you setup Talkback and play with the app keeping it on and that will give you better context.

Accessibility Guide: https://github.com/oppia/oppia-android/wiki/Accessibility-(A11y)-Guide
@rt4914 rt4914 added this to the Beta milestone Feb 5, 2021
@rt4914 rt4914 added good first issue This item is good for new contributors to make their pull request. Priority: Essential This work item must be completed for its milestone. Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. labels Feb 5, 2021
@Prince-kushwaha
Copy link
Contributor

I want to work on this issue

@rt4914
Copy link
Contributor Author

rt4914 commented Feb 17, 2021

@Prince-kushwaha Any updates on this?

@Prince-kushwaha Prince-kushwaha removed their assignment Feb 19, 2021
@rt4914 rt4914 self-assigned this Feb 23, 2021
@abhinav12k
Copy link
Contributor

@rt4914 Can i work on this issue?

@rt4914
Copy link
Contributor Author

rt4914 commented Feb 23, 2021

@abhinav12k I am assigning this to you but currently this issue is under time constraint. So if you are unable to make progress by Friday, I will have to self assign. Apologies for this inconvenience but I have to finish this project this month thats why.

@rt4914 rt4914 assigned abhinav12k and unassigned rt4914 Feb 23, 2021
@abhinav12k
Copy link
Contributor

I will inform you if I am not able to make any further progress.

@rt4914
Copy link
Contributor Author

rt4914 commented Feb 23, 2021

I will inform you if I am not able to make any further progress.

@abhinav12k Thanks a lot.

@abhinav12k abhinav12k mentioned this issue Feb 25, 2021
Merged
2 tasks
This was referenced Mar 17, 2021
Closed
Closed
BenHenning added a commit that referenced this issue Mar 25, 2021
@abhinav12k @BenHenning
Fix #2631: A11y Options Language screen (#2784)
96ad91f 
* added labels for options language screen

* a11y update

* Added Tests

* fixed spacing issues

* fix

* unused imports deleted

* Added tests for labels

* Fixed formatting issues

* Tests updated

* Removed unused imports

* merged develop

* Update app/src/sharedTest/java/org/oppia/android/app/options/AudioLanguageActivityTest.kt

Co-authored-by: Ben Henning <[email protected]>

Co-authored-by: Ben Henning <[email protected]>
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abhinav12k abhinav12k

Labels
good first issue This item is good for new contributors to make their pull request. Priority: Essential This work item must be completed for its milestone. Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #2631: A11y Options Language screen abhinav12k/oppia-android
5 participants
@rt4914 @seanlip @BenHenning @abhinav12k @Prince-kushwaha