Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full UI: ContentCardView [Blocked: #161] #26

Closed
3 tasks
BenHenning opened this issue Aug 2, 2019 · 7 comments
Closed
3 tasks

Full UI: ContentCardView [Blocked: #161] #26

BenHenning opened this issue Aug 2, 2019 · 7 comments
Assignees
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@BenHenning
Copy link
Member

BenHenning commented Aug 2, 2019

In various locations, content cards will need to be displayed with rich-text. Android TextViews support rendering a subset HTML, though the default rich-text provided by the Oppia backend may need to be processed before simply being passed to the TextView. See the web rich-text component for specifics.

Mock: https://xd.adobe.com/spec/e2239cf4-9cde-4c08-5296-25316c1f0a14-9412/screen/40d6cf5f-f673-42c8-af15-035f711ef6b9/PM-IN-Introduction-

Checklist

  • ContentCard (Left side)

Screenshot 2019-11-08 at 3 50 19 PM

  • Learner Answer (Right side)

Screenshot 2019-11-08 at 4 00 25 PM

  • Final touch up with padding, margin, animations and Accessibility Scanner test
@BenHenning BenHenning added Type: Improvement Priority: Essential This work item must be completed for its milestone. labels Aug 2, 2019
@BenHenning BenHenning added this to the Prototype milestone Aug 2, 2019
@BenHenning
Copy link
Member Author

This is blocked by #15 to retrieve exploration content data, but it can be designed & mostly built as soon as #4 is completed.

@BenHenning BenHenning changed the title Content card & rich-text rendering Content card & rich-text rendering [Blocked: #4, #15] Aug 12, 2019
@BenHenning BenHenning changed the title Content card & rich-text rendering [Blocked: #4, #15] Content card & rich-text rendering [Blocked: #15] Sep 5, 2019
@BenHenning
Copy link
Member Author

To simplify, this only needs to support basic HTML elements (li/b/etc.) + images.

@seanlip
Copy link
Member

seanlip commented Sep 9, 2019

Note: links as well. (This includes links to other lessons within the app.)

@rt4914
Copy link
Contributor

rt4914 commented Sep 10, 2019

@veena14cs @nikitamarysolomanpvt Check the comments here.

@BenHenning BenHenning changed the title Content card & rich-text rendering [Blocked: #15] Full UI: ContentCardView [Blocked: #161] Sep 20, 2019
@BenHenning
Copy link
Member Author

After talking with @veena14cs over chat today, one consideration for implementation is: https://stackoverflow.com/a/36528149/3689782.

@BenHenning
Copy link
Member Author

This is blocked on #161 for the card's initial structural implementation. Although no data controllers block this work, it should be fully tested with real Oppia HTML examples to avoid complicating downstream work items.

@veena14cs
Copy link
Contributor

This is been fixed in PR #338 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Development

No branches or pull requests

4 participants