Remove Duplicate InteractionAnswerRetriever #259
Assignees
Labels
Priority: Nice-to-have
This work item is nice to have for its milestone.
Z-ibt
Temporary label for Ben to keep track of issues he's triaged.
Comments
BenHenning
added
Priority: Nice-to-have
BenHenning
added a commit
that referenced
this issue
Nov 7, 2019
…#270) * Attempt to rebase content-card onto develop. * Manually apply rejections and remove rej files. * Add missing pieces implied in merge-fix that are needed for this branch. * Maunally apply multiple-single-input-interaction changes to develop branch (with patch rejections). * Manually apply rejected diffs. * Fix broken build after merges. * Add missing changes from merge-fix that are needed to enable state content binding. * Resolve unresolved conflicts. * Make an exploration with all prototype interactions work end-to-end. This includes: - Introducing an exploration with all prototype interactions - Introducing support for binding all interaction types - Fixing some parsing issues with fractions - Rewiring the interaction object creation for views to be generic - Removing temporary answer handling everywhere - Other random fixes This includes no tests, and there are a few other fixes still necessary for the core learning experience to fully work. * Add support for displaying feedback items. * Add support for reshowing submitted answers. * Make 'Continue' button a separate interaction (but keep the existing general 'Continue' navigation button). Rework how navigation buttons behave. Introduce automatic answer submission for some interactions (Continue, ItemSelection if it shows radio buttons, and MultipleChoice). * Move audio functionality to a custom toolbar, remove the dummy audio button, and remove the transient state name at the top of the state fragment. * Simplify the presenter by updating ExplorationProgressController to feed information about the next and current state to allow the state presenter to only focus on rendering the current state. * First batch of work corresponding to moving the entirety of state fragment's recycler view (and child views/recycler view) to be bound via data-binding. * Finish updating item selection recycler view to use data binding. This required introducing a ViewComponent that inherits from FragmentComponent in the Dagger dependency graph. This also involved updating the app to use a newer AndroidX fragment library that's still pre-release in order to gain access to the necessary functionality to associate views with their fragments. The two custom adapters have been removed in this change. * Some minor fixes to polish up the experience a bit and reduce jank. * Fix broken voiceover audio button. * Address one TODO to generalize adding interactions by leveraging a Dagger module. * Fix broken test. * Fix broken domain tests by allowing feedback to be either a string or an object, and loading about_oppia instead of oppia_exploration since the former is expected by ExplorationProgressControllerTest. * Fix broken app test builds (tests still fail, but at least run now). * Add TODO to fix feedback parsing hack. * Remove TODOs in StringToFractionParser. * Resolve open TODOs for the state portion of the player, or associate them with issues. * Associate 2 more TODOs with issues. * Add tests for new next state behavior in ExplorationProgressController, and resolve last unattributed TODO. * Remove number with units support. * Post-merge fixes and clean-ups. * Post-merge fix. * Remove number with units tests. * First round of addressing reviewer comments. * Remove view scope & component. * Second round of addressing reviewer comments. Includes a project-wide optimization of all imports. * Round 3 of addressing reviewer changes: removed UrlImageParserTest since it was pulled in with earlier, unfinalized changes and we have since realized it's not possible to test the image parser based on the current project setup. * Round 4 of addressing reviewer comments: reformat all layout XML files. * Round 5 of addressing reviewer comments. * Revert "Remove view scope & component." This reverts commit 99783d5. * Post-clean up fixes and other minor adjustments. * Ensure ExplorationActivityTest passes even though it doesn't have interesting tests yet. * Temporary workaround to make the prototype exploration accessible with recent topic & home fragment changes. Also, hide the topic button in the home fragment since the topic is accessible directly via the home fragment tiles. * Round 6 of addressing review comments. * Update prototype exploration to provide feedback after the multi-item item selection state for the correct answer so that the player doesn't seem broken.
BenHenning
moved this to Needs Triage
in [Team] Core Learner and Mastery flows & UI Frontend - Android
BenHenning
added
the
Z-ibt
seanlip
moved this from Needs Triage
to Done
in [Team] Core Learner and Mastery flows & UI Frontend - Android
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are two InteractionAnswerRetriever in respective directories:
org.oppia.app.customview.interactionorg.oppia.app.player.state.listenerWe can remove one of these and use single code everywhere.
The text was updated successfully, but these errors were encountered: