Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add all missing test in domain/BUILD.bazel #2239

Closed
anandwana001 opened this issue Dec 9, 2020 · 1 comment · Fixed by #2240
Closed

Add all missing test in domain/BUILD.bazel #2239

anandwana001 opened this issue Dec 9, 2020 · 1 comment · Fixed by #2240
Assignees
@FareesHussain
Labels
good first issue This item is good for new contributors to make their pull request. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@anandwana001
Copy link
Contributor

Is your feature request related to a problem? Please describe.
As per the Bazel, we need to mention all the test files which are inside the domain module, under the BUILD.bazel file of domain module. Some of the test files are missing.

Describe the solution you'd like

  1. Find all the test files in the domain module which are not added in the BUILD.bazel file.

    oppia-android/domain/BUILD.bazel

    Line 78 in f616e85

    domain_test(

  2. Add all the missing files
    Example -

domain_test(
    name = "NumericInputEqualsRuleClassifierProviderTest",
    srcs = ["src/test/java/org/oppia/android/domain/classify/rules/numericinput/NumericInputEqualsRuleClassifierProviderTest.kt"],
    test_class = "org.oppia.android.domain.classify.rules.numericinput.NumericInputEqualsRuleClassifierProviderTest",
    deps = TEST_DEPS,
)
@anandwana001 anandwana001 added Type: Improvement good first issue This item is good for new contributors to make their pull request. labels Dec 9, 2020
@FareesHussain
Copy link
Contributor

Please assign this to me

@FareesHussain FareesHussain mentioned this issue Dec 9, 2020
Merged
8 tasks
BenHenning pushed a commit that referenced this issue Dec 10, 2020
@FareesHussain
Fix #2239: Added Missing tests in BUILD.bazel (#2240)
fd485ee 
* Added Missing tests in BUILD.bazel

* resolving bazel build CI
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FareesHussain FareesHussain

Labels
good first issue This item is good for new contributors to make their pull request. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Task Force] Migrate to Bazel - Android
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #2239: Added Missing tests in BUILD.bazel FareesHussain/oppia-android
3 participants
@BenHenning @anandwana001 @FareesHussain