Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile Deletion in Tablet opens a different layout #2192

Closed
FareesHussain opened this issue Nov 28, 2020 · 5 comments · Fixed by #2195
Closed

Profile Deletion in Tablet opens a different layout #2192

FareesHussain opened this issue Nov 28, 2020 · 5 comments · Fixed by #2195
Assignees
Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@FareesHussain
Copy link
Contributor

Describe the bug
Profile Deletion Opens a list of profiles without toolbar

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Administrator Controls'
  2. Within 'Edit profiles' select a profile and delete the profile
  3. Opens a list of profiles and onBack press shows a empty profile info as given below

Expected behavior
Go back to Edit Profiles section in Adminstrator Controls

Screenshots

Edit Profile Selected Profile Deleting profile List of profiles without toolbar Empty Profile Info
Screenshot_1606578255 Screenshot_1606578255 Screenshot_1606578259 Screenshot_1606578264 Screenshot_1606578268

Device

  • Device/emulator being used - Nexus 7
  • SDK version - 29

Additional context
for more than one profile

@FareesHussain
Copy link
Contributor Author

Please assign this to me

I fixed this using activity.finish() instead of creating a intent as I does the same as pressing back button but using intent causes problem in tablet
image

@anandwana001
Copy link
Contributor

Please assign this to me

I fixed this using activity.finish() instead of creating a intent as I does the same as pressing back button but using intent causes problem in tablet
image

@FareesHussain For this, you also need to write test cases which should pass on both Espresso and Robolectric and should fail without your implementation.

@FareesHussain
Copy link
Contributor Author

@anandwana001 Ok i'll try
but how to vary robolectric tests for mobiles and tablets

@anandwana001
Copy link
Contributor

anandwana001 commented Nov 30, 2020

@FareesHussain Checkpoint 2 here - https://github.com/oppia/oppia-android/wiki/Oppia-Android-Testing#performance-exceptionruntime-exception-failure
Such things are already set up in the already written test files.

@FareesHussain
Copy link
Contributor Author

image

This Implementation works for both mobiles and tablets but the espresso test case is closed so I had to go with some other implementation

rt4914 pushed a commit that referenced this issue Dec 4, 2020
* fixes delete profile in tablet

* ktlint approval changes

* Resolving requested changes

* removing unused variables

* Resolving requested changes

* avoiding ktlint disable max line
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants