Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RTL] High fi Topic-Info tab #2148

Closed
rt4914 opened this issue Nov 21, 2020 · 2 comments · Fixed by #2168
Closed

[RTL] High fi Topic-Info tab #2148

rt4914 opened this issue Nov 21, 2020 · 2 comments · Fixed by #2168
Assignees
@MaskedCarrot
Labels
good first issue This item is good for new contributors to make their pull request. Priority: Essential This work item must be completed for its milestone. Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@rt4914
Copy link
Contributor

rt4914 commented Nov 21, 2020

Topic-Info needs RTL support as shown in below screen.
TP (Overview)

Make sure that this works correctly in mobile (landscape + portrait) and tablet (landscape + portrait).

References

Mobile Portrait: https://xd.adobe.com/view/e8aa4198-3940-47f9-514a-f41cc54457f6-9e9b/grid/
Mobile Landscape: https://xd.adobe.com/view/ee9e607b-dbd6-4372-48dc-b687d32af3da-98af/grid/
Tablet: https://xd.adobe.com/view/d405de00-a871-4f0f-73a0-f8acef30349b-a234/grid/
Wiki: https://github.com/oppia/oppia-android/wiki/Working-on-UI
@rt4914 rt4914 added Priority: Essential This work item must be completed for its milestone. Status: Not started good first issue This item is good for new contributors to make their pull request. Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. labels Nov 21, 2020
@rt4914 rt4914 added this to the Beta milestone Nov 21, 2020
@MaskedCarrot
Copy link
Contributor

i am working on this

@MaskedCarrot MaskedCarrot self-assigned this Nov 23, 2020
@Arjupta Arjupta mentioned this issue Nov 23, 2020
Merged
8 tasks
@rt4914
Copy link
Contributor Author

rt4914 commented Nov 23, 2020

i am working on this

Thanks.

@MaskedCarrot MaskedCarrot mentioned this issue Nov 25, 2020
Merged
8 tasks
rt4914 pushed a commit that referenced this issue Dec 4, 2020
@MaskedCarrot
Fix #2148: [RTL] High fi Topic-Info tab (#2168)
4f23e9d 
* add rtl to topic_info

* added rtl

* changed 1 story to Story 1
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MaskedCarrot MaskedCarrot

Labels
good first issue This item is good for new contributors to make their pull request. Priority: Essential This work item must be completed for its milestone. Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #2148: [RTL] High fi Topic-Info tab
5 participants
@rt4914 @seanlip @BenHenning @anandwana001 @MaskedCarrot