Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NavigationDrawerTestActivityTest for Robolectric #1968

Closed
Sarthak2601 opened this issue Oct 9, 2020 · 3 comments · Fixed by #2204
Closed

Fix NavigationDrawerTestActivityTest for Robolectric #1968

Sarthak2601 opened this issue Oct 9, 2020 · 3 comments · Fixed by #2204
Assignees
@anandwana001
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@Sarthak2601
Copy link
Contributor

Currently, NavigationDrawerTestActivityTest are passing on Espresso but they should also pass on Robolectric. Fix these below mentioned files to make sure that the tests pass on Robolectric.

You can run robolectric tests by following these steps: https://github.com/oppia/oppia-android/wiki/Oppia-Android-Testing#running-roboelectric-tests

Fixing test cases will need to introduce TextApplicationComponent. This can be seen here.
@Sarthak2601 Sarthak2601 added Priority: Essential This work item must be completed for its milestone. SLoP 2020 labels Oct 9, 2020
@Sarthak2601 Sarthak2601 added this to the Beta milestone Oct 9, 2020
@anandwana001 anandwana001 mentioned this issue Oct 12, 2020
Closed
8 tasks
@anandwana001 anandwana001 self-assigned this Nov 6, 2020
@anandwana001 anandwana001 mentioned this issue Nov 9, 2020
Merged
8 tasks
@anandwana001 anandwana001 removed their assignment Nov 9, 2020
@FareesHussain
Copy link
Contributor

FareesHussain commented Nov 14, 2020 •
edited
Loading

Please assign this to me
and what tests are left to be fixed

@anandwana001
Copy link
Contributor

anandwana001 commented Nov 14, 2020 •
edited
Loading

@FareesHussain all the tests which are marked ignore are left. This is one of the complex issue we have. In order to solve this issue please check this wiki section and all the tests should pass on both, espresso and robolectric.

https://github.com/oppia/oppia-android/wiki/Oppia-Android-Testing#tips-to-run-test-cases-in-both-espresso-and-robolectric

@FareesHussain
Copy link
Contributor

ok then I'll check if I can do that

@FareesHussain FareesHussain mentioned this issue Nov 16, 2020
Closed
7 tasks
@anandwana001 anandwana001 mentioned this issue Dec 8, 2020
Merged
8 tasks
@anandwana001 anandwana001 self-assigned this Dec 8, 2020
anandwana001 added a commit that referenced this issue Dec 11, 2020
@anandwana001
Fix #1968: Fix NavigationDrawerTestActivityTest for Robolectric (#2204)
466eb81 
* checking one test case

* adding ben's solution

* added a test

* nit fix

* removed ktlint char length disable

* nit fix naming

* rename file and function
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anandwana001 anandwana001

Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #1968: Fix NavigationDrawerTestActivityTest for Robolectric anandwana001/oppia-android
4 participants
@BenHenning @anandwana001 @Sarthak2601 @FareesHussain