Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thoroughly test ItemSelectionInputContainsAtLeastOneOfRuleClassifier #1896

Closed
Sarthak2601 opened this issue Sep 24, 2020 · 6 comments · Fixed by #2073
Closed

Thoroughly test ItemSelectionInputContainsAtLeastOneOfRuleClassifier #1896

Sarthak2601 opened this issue Sep 24, 2020 · 6 comments · Fixed by #2073
Assignees
@navneetsaluja
Labels
good first issue This item is good for new contributors to make their pull request. Hacktoberfest This is a suggested Hacktoberfest issue. Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@Sarthak2601
Copy link
Contributor

Sarthak2601 commented Sep 24, 2020 •
edited by rt4914
Loading

Since the ItemsSelectionInputContainsAtLeastOneOfRuleClassifier was copied from Oppia web, it didn't have corresponding tests added to verify correctness. These should be ported over from Oppia web as well to ensure that each classifier has working functionality.

Useful reference - https://github.com/oppia/oppia-android/tree/develop/domain/src/test/java/org/oppia/android/domain/classify/rules
@Sarthak2601 Sarthak2601 added Type: Improvement Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. good first issue This item is good for new contributors to make their pull request. labels Sep 24, 2020
@Sarthak2601 Sarthak2601 added this to the Backlog milestone Sep 24, 2020
@Sarthak2601 Sarthak2601 mentioned this issue Sep 24, 2020
Closed
29 tasks
@rt4914 rt4914 changed the title Thoroughly test ItemsSelectionInputContainsAtLeastOneOfRuleClassifier Thoroughly test ItemSelectionInputContainsAtLeastOneOfRuleClassifier Sep 26, 2020
@BenHenning BenHenning added the Hacktoberfest This is a suggested Hacktoberfest issue. label Oct 1, 2020
@navneetsaluja
Copy link
Contributor

Hi! Can I be assigned to this? I'm going to use the tips suggested by Ben here.
Thanks in advance!

@BenHenning
Copy link
Member

@navneetsaluja are you actively working on this?

@navneetsaluja
Copy link
Contributor

@BenHenning yes I am! Unfortunately due to college exams I wasn'table to work on this during the weekdays, but I'll send a PR within the next 2 days. Sorry for the delay.

@navneetsaluja navneetsaluja mentioned this issue Nov 2, 2020
Merged
8 tasks
@rt4914
Copy link
Contributor

rt4914 commented Nov 3, 2020

@BenHenning yes I am! Unfortunately due to college exams I wasn'table to work on this during the weekdays, but I'll send a PR within the next 2 days. Sorry for the delay.

@navneetsaluja Ben won't be available for sometime. In your PRs you can mention my username. Thanks.

@navneetsaluja
Copy link
Contributor

@rt4914 Sorry, I saw his mail after mentioning him in the comment (it was the same day)

@rt4914
Copy link
Contributor

rt4914 commented Nov 4, 2020

@rt4914 Sorry, I saw his mail after mentioning him in the comment (it was the same day)

No issues. Thanks.

rt4914 pushed a commit that referenced this issue Nov 18, 2020
@navneetsaluja
Fixes #1896: Thoroughly test ItemSelectionInputContainsAtLeastOneOfRu…
5724bca 
…leClassifier (#2073)

* Created a test for ItemSelectionInputContainsAtLeastOneOfRuleClassifierProvider

* Fixed lint errors

* Fixed lint errors(2)

* Added tests for more than one element and an empty set test

* Fixed lint error.

* Added function from InteractionObjectTestBuilder

* Moved function to the Builder class.
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@navneetsaluja navneetsaluja

Labels
good first issue This item is good for new contributors to make their pull request. Hacktoberfest This is a suggested Hacktoberfest issue. Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Developer Workflow & Infrastructure - Android
Archived in project
Milestone
No milestone
4 participants
@rt4914 @BenHenning @Sarthak2601 @navneetsaluja